Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable public read access to the release logs #440

Closed
wants to merge 1 commit into from
Closed

Enable public read access to the release logs #440

wants to merge 1 commit into from

Conversation

pietroalbini
Copy link
Member

r? @Mark-Simulacrum

I didn't apply this yet.

Mark-Simulacrum
Mark-Simulacrum approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably spot check a release log to check for any secret leakage, especially given sensitivity.. but I don't recall any problems so I think this is good to go.

@pietroalbini
Copy link
Member Author

Given we're going the route of invoking the release process through a local script authenticating with IAM I don't think there's a need for this anymore.

@pietroalbini pietroalbini deleted the pa-releases-public branch July 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietroalbini @Mark-Simulacrum