Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates-io: Disable versioning for rss/ contents #439

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jul 6, 2024

Note that I have absolutely no idea if the content of this PR works or not since there does not seem to be a way for me to check this, but the intention is to disable S3 versioning for all files inside the rss/ folder on S3.

r? @rust-lang/infra

@pietroalbini
Copy link
Member

You cannot disable versioning for just a subset of objects in a bucket, versioning is a global setting that applies to the whole bucket. Pushed a commit with a working version of this configuration, which deletes non-current versions of the feed after one day.

I'll let someone else in t-infra apply this (I don't have fastly keys on the machine I'm currently using).

@Turbo87
Copy link
Member Author

Turbo87 commented Jul 12, 2024

r? @rust-lang/infra ?

@jdno jdno self-assigned this Jul 17, 2024
@jdno
Copy link
Member

jdno commented Jul 17, 2024

The changes here are live on staging.

@MarcoIeni
Copy link
Member

The changes here are live on staging.

Should we merge this and apply to prod as well?

Right now terragrunt plan is not clean on master because it detects this change.

@jdno
Copy link
Member

jdno commented Aug 5, 2024

I just checked the staging bucket and each file in /rss only has the most recent version. So this seems to work and I think we can deploy it to prod as well, yes.

@MarcoIeni MarcoIeni merged commit f6b400a into rust-lang:master Aug 5, 2024
3 checks passed
@MarcoIeni
Copy link
Member

I'm deploying to prod, then 🎉

@MarcoIeni MarcoIeni mentioned this pull request Aug 5, 2024
@MarcoIeni
Copy link
Member

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants