feat: add upload-metrics-artifact GitHub Action ✨ #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look and let me know if there's anything missing. |
|
On second thought, I think we can also make this action more generic with the following name: Collect CI metrics
description: Collect CI metrics and upload them to GitHub Artifacts
inputs:
collect-metrics:
description: Whether to collect metrics or not
required: false
default: "1"
metrics-filepath:
description: Comma or space separated list of metrics files to be uploaded to GitHub artifact
required: true
default: build/cpu-usage.csv
upload-artifacts:
description: Whether to upload artifacts or not
required: false
default: "1"
runs:
using: node20
pre-if: inputs.collect-metrics == "1"
pre: collect.js
main: index.js
post-if: inputs.upload-artifacts == "1"
post: upload.jsPlease let me know if this is a better approach. Which, then, requires only one step in a job definition instead of two if we go with the first draft of this PR. |
Turbo87
reviewed
Dec 5, 2023
Comment on lines
+13
to
+17
| - name: Upload metrics artifact | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: Upload metrics | ||
| path: ${{ github.workspace }}/${{ inputs.metrics-filepath }} |
There was a problem hiding this comment.
wouldn't it be easier to use the actions/upload-artifact@v3 action directly? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rust-lang/infra-team#74
You can see the successful test-run here.