threads2: Assert jobs_done == 10 to reject non-shared solutions (#2200) - #2454
Open
GolakiyaVishal wants to merge 3 commits into
Open
GolakiyaVishal wants to merge 3 commits into
GolakiyaVishal wants to merge 3 commits into
Conversation
GolakiyaVishal
marked this pull request as ready for review
September 25, 2026 05:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2200
Problem
threads2is configured withtest = false, same as other exercises. So Rustlings only checks that the exercise compile and runs. There for user able to complete it many ways.Changes
jobs_doneas a variable instead of inclining it inprintln!.assert_eq!at the end of main so it actually check the jobs_done. So if the shared state not change then it will panic and exercise fails.solutions/20_threads/threads2.rsto match the new structure.Testing
Arc<Mutex<JobStatus>>solution passes.Arc::make_mutapproach from the issue now fails with the assertion message.cargo run -- dev checkpasses.