fix: standard English grammar/phrasing#2414
Merged
Merged
Conversation
Contributor
|
Can you also update the solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
hashmaps3.rsI always stumble and find the task hard to understand. Being a native English speaker and language nerd I find the nonnative wording in that particular task to be a further distraction from trying to grok the problem.English noun compounds only use a plural for the adjunct in rare exceptions (though it's becoming more common). "train station", "car park", and "score table" sound more idiomatic than "trains station", "cars park", or "scores table". Though "table of scores" is perhaps even more idiomatic.
There's also a nonnative English use of the simple past referring to a topic we haven't dealt with yet that I may as well fix while I'm here.