modify ListItem to hold RewriteResult as the item field #6244
+108
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
reviewed
Jul 18, 2024
ding-young
force-pushed
the
list-item
branch
2 times, most recently
from
68a1f45 to
28e5c92
Compare
ytmimi
reviewed
Jul 26, 2024
ytmimi
approved these changes
Jul 26, 2024
|
Just running the Diff-Check job on this one Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by #6206
Description
We often use
itemize_list&write_listto format list-like expressions. SinceListItemholdsOption<String>as the item field, we cannot propagateRewriteErrorfrom these functions. This pr replaces the type for the item field withRewriteResult, while modifying bound foritemize_listandwrite_list.