add skip_comments=true to neovim setup#2822
Closed
khyperia wants to merge 1 commit intorust-lang:mainfrom
Closed
Conversation
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
ah, wait, this conflicts with #2814 which is a major rewrite of the neovim section |
Contributor
Author
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the suggested neovim setup reads
src/etc/rust_analyzer_zed.jsoncomments were added to zed's json a month ago, in rust-lang/rust@6d6493a
neovim's
vim.json.decodeis spec-conformant and rejects comments as invalid json by defaultthankfully, in neovim 0.12 (released a week ago), a new option was added to
vim.json.decode,{ skip_comments = true }, which allows parsing javascript-style comments in jsonyippee!