Fix #1692: Add example for profiling diff locally #2696
Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Mattias-Petersson
force-pushed
the
fix-1692
branch
from
07db40e to
210e162
Compare
|
r? rustc-dev-guide |
There was a problem hiding this comment.
could you show this command instead
cargo run --release --bin collector
this would remove the need to indicate where the exe is located
There was a problem hiding this comment.
Done now, apologize for taking so long. I have also updated the branch to be on the latest main. (Took a few commits to get right but now it should be proper :)) Does it look okay now? :)
There was a problem hiding this comment.
I would not have bothered with updating the branch, unless there was a conflict with main. I have submitted #2712 to remove the bot messages.
There was a problem hiding this comment.
Perfect, thank you for the update :) There was no conflict with main, just how I am used to working to rebase onto the latest main branch. Good to know that it is not necessary!
This comment has been minimized.
This comment has been minimized.
Mattias-Petersson
force-pushed
the
fix-1692
branch
from
9be9888 to
b9c4ece
Compare
This comment has been minimized.
This comment has been minimized.
Mattias-Petersson
force-pushed
the
fix-1692
branch
from
b9c4ece to
36d9f2e
Compare
This comment has been minimized.
This comment has been minimized.
Mattias-Petersson
force-pushed
the
fix-1692
branch
from
36d9f2e to
a5ae29b
Compare
This comment has been minimized.
This comment has been minimized.
Mattias-Petersson
force-pushed
the
fix-1692
branch
from
a5ae29b to
b45c95a
Compare
This comment has been minimized.
This comment has been minimized.
Added an example for profiling an external crate diff locally. The original issue also mentions that the debuginfo-level = 1 should be highlighted, but that has been solved by a different commit and as such was not included here.
Changed so cargo specifies the binary collector, removing the need to link to its local binary. Clarified that the SHAs should be from the rustc-repo, but the command should be ran in the rustc-perf repo.
Mattias-Petersson
force-pushed
the
fix-1692
branch
from
b45c95a to
cadcc71
Compare
3 participants
Added an example for profiling an external crate diff locally. #1692 also mentions that the debuginfo-level = 1 should be mentioned, but that has been solved by a different commit and as such was not included here.