-
Notifications
You must be signed in to change notification settings - Fork 556
add tool to "enforce" semantic line breaks #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d1feea4 to
19d2632
Compare
|
I don't have an objection to enforcing sembr but the implementation does look fragile, e.g. there's no tokenizer. Have you considered using an existing tool like https://github.com/bobheadxi/readable? |
|
I have not... thanks for the suggestion, will have a look. |
|
I have tried using |
|
This tool of mine handles both issues without choking. I intend to get back to making it more fancy... I keep postponing. |
|
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new More context can be found here. |
4677a92 to
ee0dd75
Compare
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
|
I don't know how to do tokenization, but I attached a sample chapter to show output from the tool |
7070f1e to
d49c488
Compare
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
This comment has been minimized.
This comment has been minimized.
d49c488 to
edc1d73
Compare
See #1132
Run it so:
Diff is large, so maybe should be automated.