[rustdoc] Fix foreign items macro expansion#157115
Open
GuillaumeGomez wants to merge 1 commit into
Open
Conversation
Collaborator
|
Some changes occurred in match checking cc @Nadrieril Some changes occurred in match lowering cc @Nadrieril Some changes occurred in exhaustiveness checking cc @Nadrieril The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
May 29, 2026
Urgau
added
S-waiting-on-author
Collaborator
|
The Clippy subtree was changed cc @rust-lang/clippy |
Member
Author
|
I pushed the fix for clippy, please ignore it. Gonna apply suggestion from @fmease. |
GuillaumeGomez
force-pushed
the
fix-foreign-items-macro-expansion
branch
from
9e635a4 to
872a13f
Compare
Member
Author
|
Well you know what? All my changes were completely useless. Just kept the actual needed commit. ^^' |
Urgau
approved these changes
May 29, 2026
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 30, 2026
…acro-expansion, r=Urgau [rustdoc] Fix foreign items macro expansion Fixes rust-lang#156486. The ICE was coming from ast pretty printing not handling `...` (C var args). To handle that, I added a `CVarArgs` variants for all `PatKind` enums. Second part (and second commits) was to correctly handle foreign items in rustdoc. r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156486.
The ICE was coming from ast pretty printing not handling
...(C var args). To handle that, I added aCVarArgsvariants for allPatKindenums.Second part (and second commits) was to correctly handle foreign items in rustdoc.
r? @Urgau