Rollup of 13 pull requests#155324
Merged
rust-bors[bot] merged 30 commits intorust-lang:mainfrom Apr 15, 2026
Merged
Conversation
This especially means that for c: char, c.is_ascii() && c.is_whitespace() does **not** imply c.is_ascii_whitespace().
…min_adt_const_params`
A recent LLVM change broke these on LLVM 23.
Co-authored-by: Chris Denton <chris@chrisdenton.dev>
These comments appear to have been written before `BorrowedBuf`'s init tracking was simplified in rust-lang#150129. The `BufWriter` comment of the usage within `BufWriter` will be handled separately.
One of these has a "FIXME(autodiff): I should get used somewhere" comment, but I figure YAGNI applies and it's so small that reinstating it if necessary would be trivial.
…=BoxyUwU Gate tuple const params behind `min_adt_const_params` feature r? BoxyUwU
…, r=chenyukang explicit-tail-calls: disable two tests on LoongArch A [recent LLVM change](llvm/llvm-project#191508) broke these on LLVM 23. I suspect these will eventually be fixed, so maybe it'd be okay/better to just leave this pending so it applies to our CI without merging it? I'm open to opinions.
…umeGomez fix arch names in cfg pretty printer It's introduced in rust-lang#154328. @rustbot label +beta-nominated (it affects the documentation of [`core::arch::loongarch32`](https://doc.rust-lang.org/beta/core/arch/loongarch32/index.html) and [`core::arch::loongarch64`](https://doc.rust-lang.org/beta/core/arch/loongarch64/index.html))
`BorrowedBuf`: Update outdated safety comments in `set_init` users. These comments appear to have been written before `BorrowedBuf`'s init tracking was simplified in rust-lang#150129. The `BufWriter` comment of the usage within `BufWriter` will be handled separately. CC rust-lang#78485, rust-lang#117693.
…h-behavior, r=ChrisDenton docs: clarify path search behavior in std::process::Command::new the existing docs mentioned that `PATH` is searched in an "os defined way" and that it could be controlled by setting PATH on the command but never explained which `PATH` is actually used. on unix the key thing to understand is that when you modify the childs environment (via `env()`, `env_remove()`, or `env_clear()`), the `PATH` search uses whatever `PATH` ends up in the child's environment not the parents. so if you call `env_clear()` and forget to set `PATH`, you don't get the parents `PATH` as a fallback; you get the OS default (typically `/bin:/usr/bin`) which often won't find what you need. the three cases are now documented: - unmodified env: child inherits parents `PATH`, that gets searched - `PATH` explicitly set `via env()`: the new value is searched - `PATH` removed (`env_clear` or `env_remove`): falls back to OS default, not the parents `PATH` on windows rust resolves the executable before spawning rather than letting `CreateProcessW` do it. the search order is: childs `PATH` (if explicitly set) first then system-defined directories then the parents `PATH`. the existing note about issue rust-lang#37519 is preserved. limitations in this doc: - the unix fallback path behavior ("typically `/bin:/usr/bin`") is verified for linux/glibc. behavior on macOS, BSD, and musl is similar in practice but not fully confirmed here. - the windows search order is summarized as "system-defined directories" which actually includes the application directory (the directory of the calling process's executable) as a distinct step before the system dirs that detail is omitted for brevity. - `posix_spawnp` `PATH` source (calling process environ vs envp argument) is ambiguous in the `POSIX` spec; the behavior here is inferred from the guard in `unix.rs` that bypasses `posix_spawn` when `PATH` has been modified. closes rust-lang#137286 (hopefully)
…-Simulacrum,WaffleLapkin Clarify ascii whitespace exclusion of vertical tab in the doc This especially means that for `c: char`, `c.is_ascii() && c.is_whitespace()` does **not** imply `c.is_ascii_whitespace()`, which can cause bug and is highly counterintuitive.
…nup, r=lcnr Some small nits for supertrait_item_shadowing, and additional testing cc rust-lang#89151 r? types
…rn-white-space, r=jdonszelmann Test/lexer unicode pattern white space This PR adds a test for the Rust lexer to verify it correctly accepts vertical tab (`\x0B`) as valid whitespace between tokens. Vertical tab is part of Unicode Pattern_White_Space, which the Rust language specification uses to define whitespace. Related: Outreachy tracking [Pattern_White_Space](https://www.unicode.org/reports/tr31/#R3a)
…athanBrouwer Tests for precise-capture through RPIT and TAIT - Tests for rust-lang#155151. These tests succeed under `-Znext-solver`, but incorrectly fail under the old trait solver. --- The bug can be triggered via return-position `impl Trait` on stable, but requires some rather contrived code. When using type-alias `impl Trait`, it's easier to imagine the issue being triggered by real code.
Delete unused `rustc_trait_selection` errors. The first two of these are duplicated elsewhere in some form or another, apparently they became orphaned during various moves and refactors. The third is just never used.
remove ibraheemdev from review rotation @ibraheemdev haven't reviewed any r-l/r PRs since October last year and has a backlog of [8 PRs at the moment of writing this](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+assignee%3Aibraheemdev+label%3AS-waiting-on-review). @ibraheemdev thank you for the reviews that you have done in the past! feel free to re-add yourself once you have time for this again :)
…onathanBrouwer remove PointeeParser this parser does nothing currently, as the current scope of `rustc_attr_parsing` only includes builtin attributes, and not derive macros it isn't defined in `compiler/rustc_feature/src/builtin_attrs.rs` all the actual parsing for `#[pointee]` is actually handled in `compiler/rustc_builtin_macros/src/deriving/coerce_pointee.rs` r? @JonathanBrouwer
… r=Kivooeo Remove dead diagnostic structs. One of these has a "FIXME(autodiff): I should get used somewhere" comment, but I figure YAGNI applies and it's so small that reinstating it if necessary would be trivial. r? @Kivooeo
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bd1e7c7 (parent) -> 57cb10a (this PR) Test differencesShow 1023 test diffsStage 1
Stage 2
Additionally, 1003 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 57cb10ae1e27f54f72eb2968f6ddc8fe88b83ab5 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: bd1e7c7948 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (57cb10a): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 495.503s -> 489.055s (-1.30%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
min_adt_const_paramsfeature #154882 (Gate tuple const params behindmin_adt_const_paramsfeature)BorrowedBuf: Update outdated safety comments inset_initusers. #155314 (BorrowedBuf: Update outdated safety comments inset_initusers.)rustc_trait_selectionerrors. #155301 (Delete unusedrustc_trait_selectionerrors.)r? @ghost
Create a similar rollup