limit duplicate-profiler-builtins test to targets that can do dynamic linking#155274
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 14, 2026
Merged
limit duplicate-profiler-builtins test to targets that can do dynamic linking#155274rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
and additionally we got this output while compiling (This is a custom target, but there are other upstream targets that don't support dylibs.) |
Member
|
r? me @bors r+ rollup |
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-review
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 14, 2026
limit duplicate-profiler-builtins test to targets that can do dynamic linking this is the error I got for an example of such a target ``` === STDERR === error: extern location for dylib_a does not exist: libdylib_a.so --> main.rs:2:5 | 2 | dylib_a::something(); | ^^^^^^^ error: extern location for dylib_b does not exist: libdylib_b.so --> main.rs:3:5 | 3 | dylib_b::something_else(); | ^^^^^^^
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 14, 2026
limit duplicate-profiler-builtins test to targets that can do dynamic linking this is the error I got for an example of such a target ``` === STDERR === error: extern location for dylib_a does not exist: libdylib_a.so --> main.rs:2:5 | 2 | dylib_a::something(); | ^^^^^^^ error: extern location for dylib_b does not exist: libdylib_b.so --> main.rs:3:5 | 3 | dylib_b::something_else(); | ^^^^^^^
This was referenced Apr 14, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #154049 (delegation: Track more precise spans for glob delegations) - #155134 (Replace custom trim_ascii_start with the standard library method) - #155235 (add the `fma4` x86 target feature) - #155218 (coroutines: Skip the closure signature annotation check for tainted bodies) - #155274 (limit duplicate-profiler-builtins test to targets that can do dynamic linking) - #155276 (`#[rustc_must_match_exhaustively]` detect let else) - #155281 (Revert "allow `windows-gnu` targets to embed gdb visualizer scripts")
rust-timer
added a commit
that referenced
this pull request
Apr 14, 2026
Rollup merge of #155274 - tshepang:patch-1, r=lqd limit duplicate-profiler-builtins test to targets that can do dynamic linking this is the error I got for an example of such a target ``` === STDERR === error: extern location for dylib_a does not exist: libdylib_a.so --> main.rs:2:5 | 2 | dylib_a::something(); | ^^^^^^^ error: extern location for dylib_b does not exist: libdylib_b.so --> main.rs:3:5 | 3 | dylib_b::something_else(); | ^^^^^^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the error I got for an example of such a target