Rollup of 19 pull requests#155253
Merged
rust-bors[bot] merged 56 commits intorust-lang:mainfrom Apr 13, 2026
Merged
Conversation
…pable Some optimization passes _improve_ compile times [1]. So we want to run some passes even with `-Copt-level=0`. That means that some of the lines in the test can be optimized away. To make regression testing more robust, we also want to run the test with such passes disabled. The solution is to use two revisions. One with default `-Copt-level=0` passes, and one "even less optimized", with enough optimization passes disabled to keep the maximum number of lines steppable. [1]: rust-lang/compiler-team#319
Avoid two of its uses in diagnostic reporting and effective visibility collection. The method is only supposed to be used inside the import resolution algorithm, and the removed uses happened after import resolution already converged. Some comments are also added.
Using `self.(non_)glob_decl` directly makes it more clear.
Using `self.(non_)glob_decl` directly makes it more clear.
It is no longer needed to pass import validation, and the removal avoids some secondary errors. Also add a couple of asserts
Fixes rust-lang#154619. If `DerefPure` were dyn-compatible, a trait object of a subtrait of `DerefPure` could be created by unsize-coercing an existing type that implements `DerefPure`. But then the trait object could have its own non-pure impl of `Deref`/`DerefMut`, which is unsound, since the trait object would implement `DerefPure`. Thus, we make `DerefPure` dyn-incompatible.
The refactoring in ba46286 ("std: Use more unix.rs code on WASI targets") moved WASI from its own thread module into the shared unix.rs module. However, it did not carry over the available_parallelism() implementation for WASI, causing it to fall through to the unsupported catch-all. This silently regressed the support originally added in f0b7008. Fix this by adding WASI to the sysconf-based cfg_select arm alongside other platforms that use libc::sysconf(_SC_NPROCESSORS_ONLN). This delegates to wasi-libc, which currently always returns 1 but opens up the possibility for wasi-libc to report actual processor counts in the future. This requires libc to export _SC_NPROCESSORS_ONLN for WASI targets, which has been added in libc 0.2.184.
…tput Add a flag to control verbose subprocess output for run-make tests. When using --no-capture on panic=abort test suites like cg_clif, passing test output can flood the terminal. This flag (default true) lets users opt out via --verbose-run-make-subprocess-output=false. Extract a private print_command_output helper in run-make-support to avoid inlining the output logic in handle_failed_output, ensuring failures always print regardless of the flag.
rustbot
added
F-autodiff
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a72e2a7 (parent) -> 17584a1 (this PR) Test differencesShow 9475 test diffsStage 1
Stage 2
(and 69 additional test diffs) Additionally, 9306 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 17584a181979f04f2aaad867332c22db1caa511a --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: a72e2a71d8 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 13, 2026
Open
Collaborator
|
Finished benchmarking commit (17584a1): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.1%, secondary 1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -20.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 499.915s -> 489.468s (-2.09%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
bf16(xN)andi1xN#140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support forbf16(xN)andi1xN)InstantiatedPredicatesinsidepredicates_for_generics#155236 (Normalize individual predicate ofInstantiatedPredicatesinsidepredicates_for_generics)DerefPuredyn-incompatible #154624 (MakeDerefPuredyn-incompatible)const Defaultimpls forLazyCellandLazyLock#154929 (Addconst Defaultimpls forLazyCellandLazyLock)arena_cachequery values #154944 (Small refactor ofarena_cachequery values)tests/ui/issues/to appropriate directories #155062 (Move tests fromtests/ui/issues/to appropriate directories)uint_bit_width#155131 (Stabilize featureuint_bit_width)int_lowest_highest_one#155147 (Stabilize featureint_lowest_highest_one)UnknownDiagnosticAttributelint #155174 (Improve emission ofUnknownDiagnosticAttributelint)r? @ghost
Create a similar rollup