Skip to content

Windows: Cache the pipe filesystem handle#155250

Open
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
ChrisDenton:pipe-fs
Open

Windows: Cache the pipe filesystem handle#155250
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
ChrisDenton:pipe-fs

Conversation

@ChrisDenton
Copy link
Copy Markdown
Member

Updates the anonymous pipe handling based on feedback from @lhecker (see #142517 (comment)). This does two things:

  1. Cache the handle to the pipe filesystem so we don't have to reopen it each time.
  2. Use the \Device\NamedPipe\ directly instead of the symlink to it.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 13, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 13, 2026

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, ibraheemdev, jhpratt

Also use the `\Device\NamedPipe\` directly instead of the symlink to it.
@ChrisDenton
Copy link
Copy Markdown
Member Author

ChrisDenton commented Apr 14, 2026

r? rust-lang/libs

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

The review request libs corresponds to 7 reviewer(s).
However, none of them are available for a review at this time.
Use r? to specify someone else to assign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants