Skip to content

Rollup of 2 pull requests#155052

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-TlewACE
Apr 9, 2026
Merged

Rollup of 2 pull requests#155052
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-TlewACE

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented Apr 9, 2026

Successful merges:

r? @ghost

Create a similar rollup

oli-obk and others added 4 commits April 9, 2026 11:36
@oli-obk
Revert performing basic const checks in typeck on stable
d37d2be
@weihanglo
Update cargo submodule
6b45278
@JonathanBrouwer
Rollup merge of rust-lang#155042 - weihanglo:update-cargo, r=weihanglo
8ad51e9 
Update cargo submodule

5 commits in 101549dddbd2b08e806f50154e3aa4cb3374cc21..eb94155a9a60943bd7b1cb04abec42f5d0de6ddc
2026-04-08 12:51:20 +0000 to 2026-04-09 13:10:20 +0000
- Revert "GitHub fast path uses `http_async`" (rust-lang/cargo#16861)
- Correct spelling in cargo info man page (rust-lang/cargo#16863)
- chore: Update annotate-snippets to 0.12.15 (rust-lang/cargo#16859)
- fix(test): strip RUSTUP_TOOLCHAIN_SOURCE from test environment (rust-lang/cargo#16857)
- Support target.'cfg(..)'.rustdocflags analogously to rustflags (rust-lang/cargo#16846)

r? ghost
@JonathanBrouwer
Rollup merge of rust-lang#154930 - oli-obk:revert-const-check, r=chen…
db99e16 
…yukang

Revert performing basic const checks in typeck on stable

Revert rust-lang#149375, it caused a (desirable, but unintended) change where we now emit errors about constants in dead code. This was due to mir never seeing dead code, so no const checks being run on it. But typeck sees all written code and will check it.

We'll land this again, with a proper types FCP and everything

fixes rust-lang#153765

see [#t-types/nominated > rust-lang#153765: 1.95 beta regression: trait method calls in dead c…](https://rust-lang.zulipchat.com/#narrow/channel/326866-t-types.2Fnominated/topic/.23153765.3A.201.2E95.20beta.20regression.3A.20trait.20method.20calls.20in.20dead.20c.E2.80.A6/with/580203072) for discussions
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Apr 9, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 9, 2026

@bors r+ rollup=never p=10
Rollup of two reverts that should preferably land before the beta cutoff

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

📌 Commit db99e16 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 9, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 13m 56s
Pushing f5eca4f to main...

@rust-bors rust-bors bot merged commit f5eca4f into rust-lang:main Apr 9, 2026
12 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2026
@rustbot rustbot added this to the 1.96.0 milestone Apr 9, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 9, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#154930 Revert performing basic const checks in typeck on stable ca8e317bac86edfcf239af8f5a342e750bf6cae0 (link)
#155042 Update cargo submodule 8c61ef53f2280a622d4c3d6acb95aceb2efc10a7 (link)

previous master: a87c9b9603

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a87c9b9 (parent) -> f5eca4f (this PR)

Test differences

Show 4 test diffs

Stage 2

  • rustdocflags::target_cfg_rustdocflags_works: [missing] -> pass (J0)
  • rustdocflags::target_cfg_rustdocflags_works_through_cargo_test: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f5eca4fcfa908d1e038afd19c6e746f075859130 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 1h 46m -> 2h 32m (+43.1%)
  2. test-various: 2h 4m -> 1h 30m (-27.6%)
  3. i686-msvc-1: 3h 5m -> 2h 15m (-26.7%)
  4. aarch64-apple: 3h 20m -> 2h 51m (-14.6%)
  5. pr-check-1: 32m 41s -> 28m 13s (-13.7%)
  6. x86_64-gnu-llvm-21-3: 2h -> 1h 44m (-13.4%)
  7. dist-apple-various: 1h 51m -> 2h 6m (+13.4%)
  8. i686-gnu-1: 2h 27m -> 2h 7m (-13.4%)
  9. aarch64-gnu-llvm-21-1: 1h 3m -> 55m 9s (-13.1%)
  10. x86_64-gnu-llvm-22-1: 1h 14m -> 1h 4m (-12.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 9, 2026

Finished benchmarking commit (f5eca4f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 -0.2% [-0.2%, -0.2%] 4
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 6
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 4

Max RSS (memory usage)

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-3.6%, -1.5%] 2
All ❌✅ (primary) - - 0

Cycles

Results (primary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [-2.0%, 2.8%] 2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.938s -> 490.573s (0.13%)
Artifact size: 395.59 MiB -> 395.57 MiB (-0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rust-timer @rustbot @oli-obk @weihanglo