Closed
Conversation
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
this also reverts a fix for keywords_idents linting from other files
e7db495 to
1414bb3
Compare
JonathanBrouwer
approved these changes
Apr 9, 2026
Contributor
|
This PR should be integrated in the new attribute lint port attempt, rather than being a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155008
reverts a change from #152369 that shouldn't have been made
If I remember correctly, I made it buffer this lint at some point during the process of trying to get the lint-attrs in the right order/sorted correctly, and should've removed this.Since we now always have the attributes properly sorted now when this lint is emitted, there is no need to buffer itthe issue was caused by that there is another run through of all crate level lint attrs (which might be possible to remove in a later PR?), which overwrote the lintLevelbefore all buffered lints were emittedEdit: it has to do with the test that failed, which previously (before #152369) was wrong, see #132218 and this commit