Skip to content

KeywordIdents Lint fix#155038

Closed
Bryntet wants to merge 2 commits intorust-lang:mainfrom
Bryntet:keyword-idents-fix
Closed

KeywordIdents Lint fix#155038
Bryntet wants to merge 2 commits intorust-lang:mainfrom
Bryntet:keyword-idents-fix

Conversation

@Bryntet
Copy link
Copy Markdown
Contributor

@Bryntet Bryntet commented Apr 9, 2026

Fixes #155008

reverts a change from #152369 that shouldn't have been made

If I remember correctly, I made it buffer this lint at some point during the process of trying to get the lint-attrs in the right order/sorted correctly, and should've removed this.

Since we now always have the attributes properly sorted now when this lint is emitted, there is no need to buffer it

the issue was caused by that there is another run through of all crate level lint attrs (which might be possible to remove in a later PR?), which overwrote the lint Level before all buffered lints were emitted

Edit: it has to do with the test that failed, which previously (before #152369) was wrong, see #132218 and this commit

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 9, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

@rust-log-analyzer

This comment has been minimized.

Bryntet added 2 commits April 9, 2026 16:37
this also reverts a fix for keywords_idents linting from other files
@Bryntet Bryntet force-pushed the keyword-idents-fix branch from e7db495 to 1414bb3 Compare April 9, 2026 14:37
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if we don't revert #152369

View changes since this review

@JonathanBrouwer JonathanBrouwer added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Apr 9, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

This PR should be integrated in the new attribute lint port attempt, rather than being a separate PR

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#[expect] doesn't work anymore with pre-expansion early lints

5 participants