Skip to content

Implement GenericTypeVisitable for some types#155034

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ChayimFriedman2:ra-fixes
Apr 10, 2026
Merged

Implement GenericTypeVisitable for some types#155034
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ChayimFriedman2:ra-fixes

Conversation

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

This is required for rust-analyzer.

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
Copy link
Copy Markdown
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after doing an arbitrary amount of work on the module comment

View changes since this review

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 9, 2026

@bors delegate+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

✌️ @ChayimFriedman2, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, then please make that change and post @bors r=lcnr.

This is required for rust-analyzer.
@ChayimFriedman2
Copy link
Copy Markdown
Contributor Author

@bors r=lcnr

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

📌 Commit 6cd5315 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 9, 2026
Implement `GenericTypeVisitable` for some types

This is required for rust-analyzer.

r? types
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 9, 2026
Implement `GenericTypeVisitable` for some types

This is required for rust-analyzer.

r? types
rust-bors bot pushed a commit that referenced this pull request Apr 10, 2026
Rollup of 10 pull requests

Successful merges:

 - #154973 (Break a single query cycle in the deadlock handler)
 - #155034 (Implement `GenericTypeVisitable` for some types)
 - #151377 (Fix linker error by resolving regions for main return type obligations)
 - #154677 (hwaddress: automatically add `-Ctarget-feature=+tagged-globals`)
 - #154774 (Add myself as co-maintainer for hexagon-unknown-linux-musl)
 - #155015 (Add tests for three fixed issues (an LLVM crash, an ICE and poor codegen))
 - #155039 (minor follow up to removing soft mode `#[unstable]`)
 - #155043 (Fix if branch in op.rs)
 - #155071 (Deny `#[global_allocator]` + `#[thread_local]`)
 - #155072 (Set the Fuchsia ABI to the documented minimum)
@rust-bors rust-bors bot merged commit 6e7e947 into rust-lang:main Apr 10, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 10, 2026
rust-timer added a commit that referenced this pull request Apr 10, 2026
Rollup merge of #155034 - ChayimFriedman2:ra-fixes, r=lcnr

Implement `GenericTypeVisitable` for some types

This is required for rust-analyzer.

r? types
@ChayimFriedman2 ChayimFriedman2 deleted the ra-fixes branch April 10, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants