Skip to content

[beta] Revert performing basic const checks in typeck on stable#155033

Open
oli-obk wants to merge 1 commit intorust-lang:betafrom
oli-obk:revert-beta-const-check
Open

[beta] Revert performing basic const checks in typeck on stable#155033
oli-obk wants to merge 1 commit intorust-lang:betafrom
oli-obk:revert-beta-const-check

Conversation

@oli-obk
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk commented Apr 9, 2026

beta backport of #154930

approval in #t-compiler/backports > #154930: beta-nominated @ 💬

the nightly PR hasn't landed yet, but it will, and this is a trivial revert that only affects diagnostics

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 9, 2026

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 9, 2026

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 11 candidates

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 9, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!

@lqd lqd changed the title Revert performing basic const checks in typeck on stable [beta] Revert performing basic const checks in typeck on stable Apr 9, 2026
Copy link
Copy Markdown
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t-types, and the t-compiler voting topic, are in favor. This should be on today's t-compiler agenda to accept, and I expect it to go through. r=me when that happens, should you need it

View changes since this review

@cuviper
Copy link
Copy Markdown
Member

cuviper commented Apr 9, 2026

I'll roll this into #154999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants