tests: add whitespace tests for vertical tab behavior#155028
Open
Brace1000 wants to merge 13 commits intorust-lang:mainfrom
Open
tests: add whitespace tests for vertical tab behavior#155028Brace1000 wants to merge 13 commits intorust-lang:mainfrom
Brace1000 wants to merge 13 commits intorust-lang:mainfrom
Conversation
Add two small tests to highlight how vertical tab is handled differently. - vertical_tab_lexer.rs checks that the lexer treats vertical tab as whitespace - ascii_whitespace_excludes_vertical_tab.rs shows that split_ascii_whitespace does not split on it This helps document the difference between the Rust parser (which accepts vertical tab) and the standard library’s ASCII whitespace handling. See: rust-lang/rust-project-goals#53
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Brace1000
commented
Apr 9, 2026
This comment has been minimized.
This comment has been minimized.
fix tidy: add whitespace README entry
This comment has been minimized.
This comment has been minimized.
arrange the tittle in alphabetical order
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fix: remove unnecessary output from tests
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two small tests to highlight how vertical tab (\x0B)
is handled differently across Rust's whitespace definitions.
The Rust lexer treats vertical tab as whitespace (Unicode
Pattern_White_Space), while
split_ascii_whitespacefollows theWhatWG Infra Standard and does not include vertical tab.
These tests make that difference visible and easier to understand.
See: rust-lang/rust-project-goals#53