Skip to content

linker-messages is warn-by-default again#153968

Open
jyn514 wants to merge 3 commits intorust-lang:mainfrom
jyn514:jyn/linker-warn-by-default
Open

linker-messages is warn-by-default again#153968
jyn514 wants to merge 3 commits intorust-lang:mainfrom
jyn514:jyn/linker-warn-by-default

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 16, 2026 •
edited by rustbot
Loading

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 16, 2026
@jyn514
Copy link
Member Author

jyn514 commented Mar 16, 2026

@bors try job=dist-x86_64-llvm-mingw

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 16, 2026

@jyn514: 🔑 Insufficient privileges: not in try users

@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch 2 times, most recently from 4bab2bf to 51b5bec Compare March 16, 2026 19:07
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 16, 2026

@bors delegate=try

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 16, 2026

✌️ @jyn514, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@jyn514
Copy link
Member Author

jyn514 commented Mar 16, 2026

@bors try job=dist-x86_64-llvm-mingw

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 16, 2026
@bors
Auto merge of #153968 - jyn514:jyn/linker-warn-by-default, r=<try>
b4b60e5 
[wip] linker-messages is warn-by-default again


try-job: dist-x86_64-llvm-mingw
mati865
mati865 reviewed Mar 16, 2026
View reviewed changes
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 16, 2026

☀️ Try build successful (CI)
Build commit: b4b60e5 (b4b60e52ad96d0fa939acd7acbb42509477ac78b, parent: 3645249d79dfb136b5d8de3ce153d19d6698d92d)

@jyn514
Copy link
Member Author

jyn514 commented Mar 17, 2026

awesome, let's try all the targets now.

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 17, 2026
@bors
Auto merge of #153968 - jyn514:jyn/linker-warn-by-default, r=<try>
2d58f0b 
[wip] linker-messages is warn-by-default again
@jyn514
Copy link
Member Author

jyn514 commented Mar 17, 2026

oh i forgot that try doesn't actually run all tests in this repo oops

@jyn514 jyn514 changed the title [wip] linker-messages is warn-by-default again linker-messages is warn-by-default again Mar 17, 2026
@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch from 51b5bec to c2e1fa8 Compare March 17, 2026 08:15
@jyn514
Copy link
Member Author

jyn514 commented Mar 17, 2026

r? @mati865

@jyn514 jyn514 marked this pull request as ready for review March 17, 2026 08:15
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: codegen, compiler
  • codegen, compiler expanded to 69 candidates
  • Random selection from 13 candidates

@jyn514
Copy link
Member Author

jyn514 commented Mar 17, 2026

triagebot ???

r? mati865

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 17, 2026

☀️ Try build successful (CI)
Build commit: 2d58f0b (2d58f0bf8584cb258cd52995d2eaedfcddfcd257, parent: 3645249d79dfb136b5d8de3ce153d19d6698d92d)

@mati865
Copy link
Member

mati865 commented Mar 17, 2026

Thanks!

@bors r+ rollup=never

Note for rollups: this PR is somewhat probable to undercover new issues resulting in link errors, but if you truly want you can rollup it.

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 17, 2026

📌 Commit c2e1fa8 has been approved by mati865

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 18, 2026
@bors
Auto merge of #153968 - jyn514:jyn/linker-warn-by-default, r=mati865
8939f6e 
linker-messages is warn-by-default again
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 18, 2026

💔 Test for 8939f6e failed: CI. Failed job:

@jyn514
Revert "Remove -Alinker-messages"
9c6a01b 
This reverts commit e947492.

Now that linker-messages is warn-by-default again, turn it off in
bootstrap.
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
@jyn514
Copy link
Member Author

jyn514 commented Mar 19, 2026

I was wondering why we were getting so many new failures ... turns out that -A linker-messages was removed from bootstrap at some point. I've added it back for now, I don't want to block this for everyone on sparc-solaris bugs.

@jyn514
Copy link
Member Author

jyn514 commented Mar 19, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mati865 mati865 mati865 left review comments

Assignees

@mati865 mati865

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514 @Mark-Simulacrum @rustbot @mati865 @rust-log-analyzer @fmease