Address redundant errors for missing crate for nested imports and later uses of crate#153956
Open
yuk1ty wants to merge 2 commits intorust-lang:mainfrom
Open
Address redundant errors for missing crate for nested imports and later uses of crate#153956yuk1ty wants to merge 2 commits intorust-lang:mainfrom
yuk1ty wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
yuk1ty
force-pushed
the
fix-redundant-import-errors-nested
branch
2 times, most recently
from
ac89d2b to
594e22e
Compare
This comment has been minimized.
This comment has been minimized.
yuk1ty
force-pushed
the
fix-redundant-import-errors-nested
branch
from
594e22e to
4b6cc82
Compare
This comment has been minimized.
This comment has been minimized.
Track first segments of failed imports and skip late resolution errors for paths sharing the same prefix. This avoids redundant E0433 after an E0432 has already been reported for the same missing module, without suppressing unrelated diagnostics.
yuk1ty
force-pushed
the
fix-redundant-import-errors-nested
branch
from
4b6cc82 to
6671a98
Compare
rustbot
added
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #152913) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153156
Basically I merged redundant E0433 errors into E0432. The change seems to affect other related tests.
The first commit handles the nested import case. The second commit handles to suppress
foo::qux()pattern.