Rollup of 7 pull requests by JonathanBrouwer · Pull Request #152075 · rust-lang/rust

JonathanBrouwer · 2026-02-03T22:29:59Z

Successful merges:

const-eval: always do mem-to-mem copies if there might be padding involved #148967 (const-eval: always do mem-to-mem copies if there might be padding involved)
Use DEVELOPER_DIR instead of a custom xcode-select script #152012 (Use DEVELOPER_DIR instead of a custom xcode-select script)
Convert to inline diagnostics in rustc_incremental #152044 (Convert to inline diagnostics in rustc_incremental)
Use glob imports for attribute parsers #152046 (Use glob imports for attribute parsers)
Distinguish error message for #[diagnostic::on_const] on const trait impls #152054 (Distinguish error message for #[diagnostic::on_const] on const trait impls)
Fix some autodiff tests require Clto=fat #152059 (Fix some autodiff tests require Clto=fat)
Convert to inline diagnostics in rustc_mir_dataflow #152073 (Convert to inline diagnostics in rustc_mir_dataflow)

…olved

…t impls

`DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`.

@traviscross

…adding, r=JonathanBrouwer,traviscross const-eval: always do mem-to-mem copies if there might be padding involved This is the final piece of the puzzle for rust-lang#148470: when copying data of a type that has padding, always do a mem-to-mem copy, so that we always preserve the source padding exactly. That prevents rustc implementation choices from leaking into user-visible behavior. This is technically a breaking change: the example at the top of rust-lang#148470 no longer compiles with this. However, it seems very unlikely that anyone would have depended on this. My main concern is not backwards compatibility, it is performance. Fixes rust-lang#148470 --- > Actually that seems to be entirely fine, it even helps with some benchmarks! I guess the mem-to-mem codepath is actually faster than the scalar pair codepath for the copy itself. It can slow things down later since now we have to do everything bytewise, but that doesn't show up in our benchmarks and might not be very relevant after all (in particular, it only affects types with padding, so the rather common wide pointers still always use the efficient scalar representation). > > So that would be my proposal to for resolving this issue then: to make const-eval behavior consistent, we always copy the padding from the source to the target. IOW, potentially pre-existing provenance in the target always gets overwritten (that part is already in rust-lang#148259), and potentially existing provenance in padding in the source always gets carried over (that's rust-lang#148967). If there's provenance elsewhere in the source our existing handling is fine: > - If it's in an integer, that's UB during const-eval so we can do whatever. > - If it's in a pointer, the the fragments must combine back together to a pointer or else we have UB. > - If it's in a union we just carry it over unchanged. > > @traviscross we should check that this special const-eval-only UB is properly reflected in the reference. Currently we have [this](https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html#r-undefined.const-transmute-ptr2int) but that only talks about int2ptr, not about invalid pointer fragments at pointer type. I also wonder if this shouldn't rather be part of ["invalid values"](https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html#r-undefined.validity) to make it clear that this applies recursively inside fields as well. > EDIT: Reference PR is up at rust-lang/reference#2091. _Originally posted by @RalfJung in [rust-lang#148470](rust-lang#148470 (comment) > Worth noting that this does not resolve the concerns @theemathas had about `-Zextra-const-ub-checks` sometimes causing *more* code to compile. Specifically, with that flag, the behavior changes to "potentially existing provenance in padding in the source never gets carried over". However, it's a nightly-only flag (used by Miri) so while the behavior is odd, I don't think this is a problem. _Originally posted by @RalfJung in [rust-lang#148470](rust-lang#148470 (comment) --- Related: - rust-lang#148470 - rust-lang/reference#2091

Use `DEVELOPER_DIR` instead of a custom `xcode-select` script `DEVELOPER_DIR` is the standard environment variable for overriding the Xcode version, there is no need to invoke `xcode-select --switch` manually to do this. The variable is documented in both `man xcode-select` and `man xcrun`. Using this makes reproducing things locally a little easier (you can just copy the env var). r? shepmaster

…convert, r=lqd Convert to inline diagnostics in `rustc_incremental` For rust-lang#151366

…ouwer Use glob imports for attribute parsers r? JonathanBrouwer

…, r=estebank Distinguish error message for `#[diagnostic::on_const]` on const trait impls context: rust-lang#149627 (comment) Sorry for the delay between receiving the review and submitting this patch. I'll ask the original proposer to review it. r? estebank

…ZuseZ4 Fix some autodiff tests require Clto=fat It seems that some tests in tests/run-make/autodiff/type-trees/ require -Clto=fat at least on macos There are several types of errors in tests/run-make/autodiff now. I fixed the easiest one to reduce the noise. I'll look into another errors after this PR. I confirmed tests have passed. ```shell ./x test --stage 1 tests/run-make/autodiff/type-trees/array-typetree -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/mixed-struct-typetree -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/nott-flag -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/recursion-typetree -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/scalar-types -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/slice-typetree -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/struct-typetree -- --ignored ./x test --stage 1 tests/run-make/autodiff/type-trees/tuple-typetree -- --ignored Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.11s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.43s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.10s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.14s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.10s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.21s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.34s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.35s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 2.32s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:12 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.12s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 1.05s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.29s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.29s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.09s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.09s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.23s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.14s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 2.37s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:12 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.11s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.81s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.35s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.24s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.10s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.19s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.25s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.15s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 1.34s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:13 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.28s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.38s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.28s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.23s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.49s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.19s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.41s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.36s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 2.30s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:13 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.22s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Compiling rustc_session v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_session) Compiling rustc_query_system v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_query_system) Compiling rustc_parse v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_parse) Compiling rustc_middle v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_middle) Compiling rustc_attr_parsing v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_attr_parsing) Compiling rustc_ast_passes v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_ast_passes) Compiling rustc_transmute v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_transmute) Compiling rustc_infer v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_infer) Compiling rustc_expand v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_expand) Compiling rustc_incremental v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_incremental) Compiling rustc_mir_dataflow v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_mir_dataflow) Compiling rustc_symbol_mangling v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_symbol_mangling) Compiling rustc_ast_lowering v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_ast_lowering) Compiling rustc_pattern_analysis v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_pattern_analysis) Compiling rustc_public_bridge v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_public_bridge) Compiling rustc_query_impl v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_query_impl) Compiling rustc_monomorphize v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_monomorphize) Compiling rustc_public v0.1.0-preview (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_public) Compiling rustc_metadata v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_metadata) Compiling rustc_trait_selection v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_trait_selection) Compiling rustc_builtin_macros v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_builtin_macros) Compiling rustc_resolve v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_resolve) Compiling rustc_lint v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_lint) Compiling rustc_ty_utils v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_ty_utils) Compiling rustc_privacy v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_privacy) Compiling rustc_codegen_ssa v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_codegen_ssa) Compiling rustc_const_eval v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_const_eval) Compiling rustc_sanitizers v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_sanitizers) Compiling rustc_hir_analysis v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_hir_analysis) Compiling rustc_traits v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_traits) Compiling rustc_borrowck v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_borrowck) Compiling rustc_mir_transform v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_mir_transform) Compiling rustc_hir_typeck v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_hir_typeck) Compiling rustc_codegen_llvm v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_codegen_llvm) Compiling rustc_mir_build v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_mir_build) Compiling rustc_passes v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_passes) Compiling rustc_interface v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_interface) Compiling rustc_driver_impl v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_driver_impl) Compiling rustc_driver v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc_driver) Compiling rustc-main v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/compiler/rustc) Finished `release` profile [optimized] target(s) in 2m 51s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.37s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.17s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.42s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Compiling shlex v1.3.0 Compiling core v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/core) Compiling libc v0.2.178 Compiling object v0.37.3 Compiling std v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/std) Compiling test v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/test) Compiling cc v1.2.0 Compiling compiler_builtins v0.1.160 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/compiler-builtins/compiler-builtins) Compiling rustc-std-workspace-core v1.99.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/rustc-std-workspace-core) Compiling alloc v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/alloc) Compiling adler2 v2.0.1 Compiling memchr v2.7.6 Compiling panic_abort v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/panic_abort) Compiling rustc-demangle v0.1.27 Compiling cfg-if v1.0.4 Compiling rustc-literal-escaper v0.0.7 Compiling unwind v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/unwind) Compiling rustc-std-workspace-alloc v1.99.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/rustc-std-workspace-alloc) Compiling panic_unwind v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/panic_unwind) Compiling gimli v0.32.3 Compiling hashbrown v0.16.1 Compiling std_detect v0.1.5 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/std_detect) Compiling miniz_oxide v0.8.9 Compiling addr2line v0.25.1 Compiling rustc-std-workspace-std v1.99.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/rustc-std-workspace-std) Compiling proc_macro v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/proc_macro) Compiling getopts v0.2.24 Compiling sysroot v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/library/sysroot) Finished `dist` profile [optimized] target(s) in 34.54s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.40s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Compiling rustdoc v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/src/librustdoc) Compiling rustdoc-tool v0.0.0 (/Volumes/WD_BLACK_SN850X_HS_1TB/autodiff-rust/rust/src/tools/rustdoc) Finished `release` profile [optimized] target(s) in 37.79s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 5 tests ..... test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 456 filtered out; finished in 2.41s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:04:18 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.12s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.71s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.11s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.07s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.09s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.15s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.34s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.28s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 2.04s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:13 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.11s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.82s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.38s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.08s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.09s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.09s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.21s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.14s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 1.37s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:12 Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.15s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` Building stage1 compiler artifacts (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.37s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 wasm-component-ld (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.35s Building stage1 llvm-bitcode-linker (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.35s Building stage1 run_make_support (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.29s Building stage1 library artifacts (stage1 -> stage1, aarch64-apple-darwin) Finished `dist` profile [optimized] target(s) in 0.12s Building stage1 compiletest (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.46s Building stage1 rustdoc_tool_binary (stage0 -> stage1, aarch64-apple-darwin) Finished `release` profile [optimized] target(s) in 0.23s Testing stage1 with compiletest suite=run-make mode=run-make (aarch64-apple-darwin) running 1 tests . test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 460 filtered out; finished in 1.41s WARNING: The `change-id` is missing in the `bootstrap.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations. NOTE: to silence this warning, add `change-id = 148671` or `change-id = "ignore"` at the top of `bootstrap.toml` NOTE: this message was printed twice to make it more likely to be seen Build completed successfully in 0:00:12 ```

@jdonszelmann

…ow, r=lqd Convert to inline diagnostics in `rustc_mir_dataflow` For rust-lang#151366 r? @jdonszelmann

JonathanBrouwer · 2026-02-03T22:30:05Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-03T22:30:08Z

📌 Commit 7960088 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-02-04T04:36:01Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 7m 6s
Pushing 1d05e3c to main...

rust-timer · 2026-02-04T04:37:59Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#148967	const-eval: always do mem-to-mem copies if there might be p…	`67ecc0ea12ffdc55016786e853920590ee85ccaf` (link)
#152012	Use `DEVELOPER_DIR` instead of a custom `xcode-select` scri…	`bf93cfc1080c0fc7b24f9a0c4713ac361f9f8ee4` (link)
#152044	Convert to inline diagnostics in `rustc_incremental`	`60a4c3dc4e8ba01a480b73b71cc5f43b2e04ae2e` (link)
#152046	Use glob imports for attribute parsers	`4ea6ce2abeff972fe94fef7be6ce9c9365f4dde2` (link)
#152054	Distinguish error message for `#[diagnostic::on_const]` on …	`0878ec0e4f7575e10d178e31f23a8ec7b35dc869` (link)
#152059	Fix some autodiff tests require Clto=fat	`68a5e4ac596e8e20814d624045cfbe9de02f96c9` (link)
#152073	Convert to inline diagnostics in `rustc_mir_dataflow`	`f620029acf9bb452979571c2fbdbc6a62fcf252e` (link)

previous master: 0c40f5be0c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-02-04T04:38:34Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0c40f5b (parent) -> 1d05e3c (this PR)

Test differences

Show 526 test diffs

Stage 0

errors::verify_incremental_canonicalize_path_21: pass -> [missing] (J0)
errors::verify_incremental_create_lock_23: pass -> [missing] (J0)
errors::verify_incremental_delete_lock_24: pass -> [missing] (J0)
errors::verify_incremental_missing_if_this_changed_2: pass -> [missing] (J0)
errors::verify_incremental_move_dep_graph_36: pass -> [missing] (J0)
errors::verify_incremental_not_dirty_10: pass -> [missing] (J0)
errors::verify_incremental_undefined_clean_dirty_assertions_7: pass -> [missing] (J0)
errors::verify_mir_dataflow_peek_argument_not_a_local_4: pass -> [missing] (J0)
errors::verify_mir_dataflow_stop_after_dataflow_ended_compilation_0: pass -> [missing] (J0)
errors::verify_passes_attr_application_struct_enum_union_71: [missing] -> pass (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_101: pass -> [missing] (J0)
errors::verify_passes_deprecated_annotation_has_no_effect_40: [missing] -> pass (J0)
errors::verify_passes_deprecated_attribute_73: [missing] -> pass (J0)
errors::verify_passes_doc_fake_variadic_not_valid_13: pass -> [missing] (J0)
errors::verify_passes_doc_inline_only_use_17: pass -> [missing] (J0)
errors::verify_passes_doc_search_unbox_invalid_15: pass -> [missing] (J0)
errors::verify_passes_duplicate_feature_err_81: pass -> [missing] (J0)
errors::verify_passes_eii_fn_with_track_caller_103: pass -> [missing] (J0)
errors::verify_passes_eii_without_impl_105: [missing] -> pass (J0)
errors::verify_passes_extern_main_61: pass -> [missing] (J0)
errors::verify_passes_extern_main_62: [missing] -> pass (J0)
errors::verify_passes_feature_previously_declared_59: pass -> [missing] (J0)
errors::verify_passes_function_not_have_default_implementation_106: pass -> [missing] (J0)
errors::verify_passes_functions_names_duplicated_109: [missing] -> pass (J0)
errors::verify_passes_implied_feature_not_exist_81: [missing] -> pass (J0)
errors::verify_passes_incorrect_do_not_recommend_location_3: [missing] -> pass (J0)
errors::verify_passes_ineffective_unstable_impl_88: [missing] -> pass (J0)
errors::verify_passes_lang_item_on_incorrect_target_46: pass -> [missing] (J0)
errors::verify_passes_layout_align_51: [missing] -> pass (J0)
errors::verify_passes_layout_homogeneous_aggregate_52: pass -> [missing] (J0)
errors::verify_passes_layout_size_52: [missing] -> pass (J0)
errors::verify_passes_link_21: pass -> [missing] (J0)
errors::verify_passes_may_dangle_36: pass -> [missing] (J0)
errors::verify_passes_missing_const_err_83: [missing] -> pass (J0)
errors::verify_passes_missing_const_stab_attr_77: pass -> [missing] (J0)
errors::verify_passes_missing_const_stab_attr_78: [missing] -> pass (J0)
errors::verify_passes_missing_lang_item_43: pass -> [missing] (J0)
errors::verify_passes_missing_panic_handler_41: pass -> [missing] (J0)
errors::verify_passes_missing_panic_handler_42: [missing] -> pass (J0)
errors::verify_passes_non_exhaustive_with_default_field_values_9: [missing] -> pass (J0)
errors::verify_passes_non_exported_macro_invalid_attrs_35: pass -> [missing] (J0)
errors::verify_passes_proc_macro_bad_sig_85: [missing] -> pass (J0)
errors::verify_passes_repr_align_greater_than_target_max_27: pass -> [missing] (J0)
errors::verify_passes_rustc_allow_const_fn_unstable_31: pass -> [missing] (J0)
errors::verify_passes_rustc_const_stable_indirect_pairing_90: [missing] -> pass (J0)
errors::verify_passes_rustc_legacy_const_generics_only_23: [missing] -> pass (J0)
errors::verify_passes_rustc_pub_transparent_33: [missing] -> pass (J0)
errors::verify_passes_unknown_lang_item_47: pass -> [missing] (J0)
errors::verify_passes_unknown_lang_item_48: [missing] -> pass (J0)
errors::verify_passes_unsupported_attributes_in_where_91: [missing] -> pass (J0)
errors::verify_passes_unused_multiple_38: pass -> [missing] (J0)
errors::verify_passes_useless_stability_74: [missing] -> pass (J0)

Stage 1

errors::verify_incremental_assert_loaded_33: pass -> [missing] (J1)
errors::verify_incremental_canonicalize_path_21: pass -> [missing] (J1)
errors::verify_incremental_create_new_19: pass -> [missing] (J1)
errors::verify_incremental_delete_full_27: pass -> [missing] (J1)
errors::verify_incremental_undefined_clean_dirty_assertions_7: pass -> [missing] (J1)
errors::verify_mir_dataflow_peek_argument_not_a_local_4: pass -> [missing] (J1)
errors::verify_passes_abi_ne_55: pass -> [missing] (J1)
errors::verify_passes_abi_of_54: pass -> [missing] (J1)
errors::verify_passes_abi_of_55: [missing] -> pass (J1)
errors::verify_passes_attr_application_struct_68: pass -> [missing] (J1)
errors::verify_passes_const_continue_attr_5: pass -> [missing] (J1)
errors::verify_passes_deprecated_annotation_has_no_effect_39: pass -> [missing] (J1)
errors::verify_passes_deprecated_attribute_73: [missing] -> pass (J1)
errors::verify_passes_doc_alias_bad_location_10: [missing] -> pass (J1)
errors::verify_passes_doc_fake_variadic_not_valid_14: [missing] -> pass (J1)
errors::verify_passes_doc_inline_only_use_18: [missing] -> pass (J1)
errors::verify_passes_doc_keyword_only_impl_15: [missing] -> pass (J1)
errors::verify_passes_duplicate_feature_err_81: pass -> [missing] (J1)
errors::verify_passes_duplicate_feature_err_82: [missing] -> pass (J1)
errors::verify_passes_eii_impl_not_function_103: [missing] -> pass (J1)
errors::verify_passes_implied_feature_not_exist_80: pass -> [missing] (J1)
errors::verify_passes_implied_feature_not_exist_81: [missing] -> pass (J1)
errors::verify_passes_incorrect_crate_type_63: pass -> [missing] (J1)
errors::verify_passes_ineffective_unstable_impl_88: [missing] -> pass (J1)
errors::verify_passes_inline_ignored_for_exported_65: pass -> [missing] (J1)
errors::verify_passes_inner_crate_level_attr_8: [missing] -> pass (J1)
errors::verify_passes_lang_item_fn_with_target_feature_45: pass -> [missing] (J1)
errors::verify_passes_lang_item_fn_with_track_caller_44: pass -> [missing] (J1)
errors::verify_passes_lang_item_fn_with_track_caller_45: [missing] -> pass (J1)
errors::verify_passes_layout_of_54: [missing] -> pass (J1)
errors::verify_passes_macro_only_attribute_29: pass -> [missing] (J1)
errors::verify_passes_may_dangle_36: pass -> [missing] (J1)
errors::verify_passes_multiple_rustc_main_60: pass -> [missing] (J1)
errors::verify_passes_object_lifetime_err_67: [missing] -> pass (J1)
errors::verify_passes_repr_conflicting_26: pass -> [missing] (J1)
errors::verify_passes_rustc_const_stable_indirect_pairing_90: [missing] -> pass (J1)
errors::verify_passes_rustc_force_inline_coro_34: [missing] -> pass (J1)
errors::verify_passes_rustc_legacy_const_generics_index_exceed_25: [missing] -> pass (J1)
errors::verify_passes_trait_impl_const_stable_79: [missing] -> pass (J1)
errors::verify_passes_transparent_incompatible_72: [missing] -> pass (J1)
errors::verify_passes_unexportable_generic_fn_93: [missing] -> pass (J1)
errors::verify_passes_unexportable_priv_item_96: pass -> [missing] (J1)
errors::verify_passes_unexportable_type_in_interface_96: [missing] -> pass (J1)
errors::verify_passes_unexportable_type_repr_94: pass -> [missing] (J1)
errors::verify_passes_unknown_feature_alias_79: pass -> [missing] (J1)
errors::verify_passes_unknown_lang_item_47: pass -> [missing] (J1)
errors::verify_passes_unnecessary_stable_feature_85: pass -> [missing] (J1)
errors::verify_passes_useless_assignment_64: pass -> [missing] (J1)

(and 424 additional test diffs)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1d05e3c131d7181eb3df1a8c261f43135c99200d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 2h 29m -> 1h 52m (-24.7%)
aarch64-apple: 2h 33m -> 2h 58m (+16.5%)
dist-aarch64-llvm-mingw: 1h 53m -> 1h 35m (-15.8%)
aarch64-msvc-2: 1h 37m -> 1h 52m (+15.4%)
x86_64-gnu-llvm-20-1: 1h 16m -> 1h 7m (-12.0%)
aarch64-gnu-llvm-20-2: 57m 50s -> 51m 7s (-11.6%)
dist-aarch64-msvc: 1h 53m -> 1h 40m (-11.4%)
x86_64-gnu-debug: 2h 7m -> 1h 54m (-10.2%)
dist-x86_64-freebsd: 1h 22m -> 1h 31m (+10.1%)
dist-apple-various: 1h 10m -> 1h 3m (-9.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-04T05:22:24Z

Finished benchmarking commit (1d05e3c): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.2%, 1.4%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	15
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[1.7%, 2.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[1.7%, 2.4%]	2

Cycles

Results (primary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.4%, 2.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[1.4%, 2.0%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.191s -> 476.238s (0.22%)
Artifact size: 397.77 MiB -> 397.76 MiB (-0.00%)

JonathanBrouwer · 2026-02-04T09:21:23Z

#148967 fully explains all regressions but not all perf gains

RalfJung and others added 15 commits January 19, 2026 17:56

const-eval: always do mem-to-mem copies if there might be padding inv…

635bacf

…olved

add fast-path for wide pointers

5a76a60

Distinguish error message for #[diagnostic::on_const] on const trai…

dfc60ae

…t impls

Fix some autodiff tests require Clto=fat

6c4abb7

Convert to inline diagnostics in rustc_incremental

4cacfc0

Convert to inline diagnostics in rustc_mir_dataflow

4fdd085

Use glob imports for attribute parsers

828bead

Rollup merge of rust-lang#152044 - JonathanBrouwer:rustc_incremental_…

df2daa3

…convert, r=lqd Convert to inline diagnostics in `rustc_incremental` For rust-lang#151366

Rollup merge of rust-lang#152046 - clubby789:glob-attrs, r=JonathanBr…

1e15bda

…ouwer Use glob imports for attribute parsers r? JonathanBrouwer

Rollup merge of rust-lang#152073 - JonathanBrouwer:convert_mir_datafl…

7960088

…ow, r=lqd Convert to inline diagnostics in `rustc_mir_dataflow` For rust-lang#151366 r? @jdonszelmann

rust-bors bot added the rollup A PR which is a rollup label Feb 3, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 4, 2026

rust-bors bot merged commit 1d05e3c into rust-lang:main Feb 4, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 4, 2026

rust-bors bot mentioned this pull request Feb 4, 2026

Convert to inline diagnostics in rustc_interface #152047

Merged

rustbot added the perf-regression Performance regression. label Feb 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#152075

Rollup of 7 pull requests#152075
rust-bors[bot] merged 15 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-TaaDPXF

JonathanBrouwer commented Feb 3, 2026

Uh oh!

JonathanBrouwer commented Feb 3, 2026

Uh oh!

rust-bors bot commented Feb 3, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 4, 2026

Uh oh!

Uh oh!

rust-timer commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Stage 0

Stage 1

Uh oh!

rust-timer commented Feb 4, 2026

Uh oh!

JonathanBrouwer commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

JonathanBrouwer commented Feb 3, 2026

Uh oh!

JonathanBrouwer commented Feb 3, 2026

Uh oh!

rust-bors bot commented Feb 3, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 4, 2026

Uh oh!

Uh oh!

rust-timer commented Feb 4, 2026

Uh oh!

github-actions bot commented Feb 4, 2026

Test differences

Stage 0

Stage 1

Job duration changes

Uh oh!

rust-timer commented Feb 4, 2026

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants