Rollup of 11 pull requests #152025

jhpratt · 2026-02-03T04:12:10Z

Successful merges:

Codegen tests for Arm Cortex-R82 #151378 (Codegen tests for Arm Cortex-R82)
Move the fingerprint_style special case into DepKindVTable creation #151936 (Move the fingerprint_style special case into DepKindVTable creation)
Move bigint helper tracking issues #152018 (Move bigint helper tracking issues)
Add codegen test for SLP vectorization #151958 (Add codegen test for SLP vectorization)
Update documentation for Result::ok() #151974 (Update documentation for Result::ok())
Work around rustfmt giving up on a large expression #151975 (Work around rustfmt giving up on a large expression)
Fix missing unused_variables lint when using a match guard #151990 (Fix missing unused_variables lint when using a match guard)
stabilize ptr_as_ref_unchecked #151995 (stabilize ptr_as_ref_unchecked)
attribute parsing: pass recovery mode to Parser. #151999 (attribute parsing: pass recovery mode to Parser.)
Port rustc_preserve_ub_checks to attr parser #152009 (Port rustc_preserve_ub_checks to attr parser)
rustc-dev-guide subtree update #152022 (rustc-dev-guide subtree update)

Failed merges:

Remove HasDepContext by merging it into QueryContext #151968 (Remove HasDepContext by merging it into QueryContext)

This PR adds checks to the `aarch64v8r-unknown-none` target to verify that if the Cortex-R82 CPU is enabled (with `-Ctarget-cpu=cortex-r82`), that the appropriate additional AArch64 features are enabled. This is important because Cortex-R82 is (currently) the only processor implementing Armv8-R AArch64 and it implements a number of Armv8 features over and above the baseline for the architecture. Many of these features are of interest to safety-critical firmware development (for example `FEAT_RASv1p1`, which adds support for the *RAS Common Fault Injection Model Extension*) and so we anticipate them being enabled when building such firmware. We are offering these tests upstream in-lieu of a full Cortex-R82 specific target because we understand the Project has a preference for architecture-baseline targets over CPU-specific targets. This PR builds on and requires rust-lang#150863, but we've pulled them out as a separate PR. This PR was developed by Ferrous Systems on behalf of Arm. Arm is the owner of these changes.

fix adk installer link

This updates the rust-version file to 44e34e1.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@44e34e1 Filtered ref: rust-lang/rustc-dev-guide@e740092 Upstream diff: rust-lang/rust@370143f...44e34e1 This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

Fix typo in debugging.md

Fix tense

It is awkward to continue a sentence after a code block

suggested.md: improve a bit

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.

external-rustc-drivers.md: some style improvements

Within a binding pattern match guard, only real reads of a bound local impact its liveness analysis - not the fake read that is injected.

Co-authored-by: Nikita Popov <[email protected]>

jhpratt · 2026-02-03T04:12:31Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-03T04:12:34Z

📌 Commit 3b8a503 has been approved by jhpratt

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

rust-bors · 2026-02-03T07:57:01Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 12m 46s
Pushing 46c86ae to main...

github-actions · 2026-02-03T07:59:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5ac8ece (parent) -> 46c86ae (this PR)

Test differences

Show 52 test diffs

Stage 1

[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (ignored when the LLVM version 20.1.2 is older than 22.0.0) (J2)
[ui] tests/ui/asm/aarch64v8r.rs#r82: [missing] -> pass (J3)
[ui] tests/ui/asm/cortex-r82.rs: [missing] -> pass (J3)
[ui] tests/ui/lint/unused/match_with_guard.rs: [missing] -> pass (J3)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J9)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J10)

Stage 2

[ui] tests/ui/asm/aarch64v8r.rs#r82: [missing] -> ignore (gcc backend is marked as ignore) (J0)
[ui] tests/ui/asm/cortex-r82.rs: [missing] -> ignore (gcc backend is marked as ignore) (J0)
[ui] tests/ui/asm/aarch64v8r.rs#r82: [missing] -> pass (J1)
[ui] tests/ui/asm/cortex-r82.rs: [missing] -> pass (J1)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J4)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (ignored when the LLVM version 20.1.2 is older than 22.0.0) (J5)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (ignored when the LLVM version 20.1.8 is older than 22.0.0) (J6)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J7)
[codegen] tests/codegen-llvm/slp-vectorization-mul3.rs: [missing] -> pass (J8)
[ui] tests/ui/lint/unused/match_with_guard.rs: [missing] -> pass (J11)

Additionally, 36 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-gcc
J1: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-llvm-20, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-21-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J2: x86_64-gnu-llvm-20-3
J3: x86_64-gnu-llvm-20-3, x86_64-gnu-llvm-21-3
J4: aarch64-apple, aarch64-gnu, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1
J5: x86_64-gnu-llvm-20-2
J6: aarch64-gnu-llvm-20-1
J7: x86_64-gnu-llvm-21-2
J8: test-various, x86_64-gnu, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J9: x86_64-gnu-llvm-21-3
J10: pr-check-2
J11: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-gcc, x86_64-gnu-llvm-20, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-21-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 46c86aef65a8529b8c989077ade26d17d2b4c95d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3798.5s -> 5374.8s (+41.5%)
dist-x86_64-apple: 7316.1s -> 8512.8s (+16.4%)
dist-ohos-x86_64: 4261.0s -> 4788.5s (+12.4%)
x86_64-gnu-llvm-20: 4147.1s -> 4639.5s (+11.9%)
pr-check-1: 1947.6s -> 1724.8s (-11.4%)
tidy: 157.2s -> 172.8s (+9.9%)
armhf-gnu: 4963.7s -> 5434.5s (+9.5%)
dist-aarch64-apple: 6870.4s -> 6246.5s (-9.1%)
x86_64-gnu-llvm-21-3: 6322.6s -> 6896.5s (+9.1%)
x86_64-gnu-llvm-21-1: 4142.4s -> 4514.0s (+9.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-03T08:00:06Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151378	Codegen tests for Arm Cortex-R82	`f488d070e3f1f9e966b233c898fdec46774e9994` (link)
#151936	Move the `fingerprint_style` special case into `DepKindVTab…	`32791a16f7f1745085925e7c4711e3d8ca8dc73a` (link)
#151958	Add codegen test for SLP vectorization	`ca3a6cf80d28dc858250213c745b3d743f2a8781` (link)
#151974	Update documentation for `Result::ok()`	`9121ebd4b67c0dc5bd95b54a782d0a111e4a3b92` (link)
#151975	Work around rustfmt giving up on a large expression	`5626e21a4bf87f0550b1e34c18eafcd5e1f466d4` (link)
#151990	Fix missing unused_variables lint when using a match guard	`6e4569597958238cff97d85e1009de1907b1230f` (link)
#151995	stabilize ptr_as_ref_unchecked	`318fc310fbc9b056814d7e7f309e7b6a7f07178e` (link)
#151999	attribute parsing: pass recovery mode to Parser.	`63f1b91e2c91b720bcebd93ce4185dc66fe33205` (link)
#152009	Port rustc_preserve_ub_checks to attr parser	`ba3cc2ef856c332141c80f7221962a300b223c41` (link)
#152018	Move bigint helper tracking issues	`5606cfd1fbb2345bdc70ba6dd70175abdfb6d275` (link)
#152022	rustc-dev-guide subtree update	`9857c2a6260ebcd48696450676633a8ff7ed36e8` (link)

previous master: 5ac8ecea36

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-02-03T08:49:28Z

Finished benchmarking commit (46c86ae): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.3%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.2%, 1.8%]	2
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-2.0%, 1.8%]	3

Cycles

Results (secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[2.1%, 5.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	42
Regressions ❌ (secondary)	0.2%	[0.0%, 0.3%]	66
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.3%]	42

Bootstrap: 474.688s -> 474.728s (0.01%)
Artifact size: 397.75 MiB -> 397.84 MiB (0.02%)

jonathanpallant and others added 30 commits January 27, 2026 14:06

fix adk installer link

5f76adf

Merge pull request rust-lang#2751 from reddevilmidzy/fix

c57471e

fix adk installer link

Fix typo in debugging.md

5cb9163

Prepare for merging from rust-lang/rust

c8d2f3e

This updates the rust-version file to 44e34e1.

Merge pull request rust-lang#2753 from rust-lang/rustc-pull

8a133ce

Rustc pull update

Fix tense

a77b9e6

Merge pull request rust-lang#2752 from thealtofwar/patch-1

48a76d2

Fix typo in debugging.md

Merge pull request rust-lang#2754 from ada4a/patch-3

3f3a544

Fix tense

suggested.md: improve a bit

4cf181b

It is awkward to continue a sentence after a code block

Merge pull request rust-lang#2757 from rust-lang/tshepang-patch-2

15bba04

suggested.md: improve a bit

Move the fingerprint_style special case into DepKindVTable creation

b4bf57b

Add codegen test for SLP vectorization

2292d53

fix: remove trailing newline for tidy

0a60bd6

Restrict test to x86_64 per reviewer feedback

1c396d2

Update documentation for Result::ok()

f3b7a1a

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.

Add backlink to issue

c64f9a0

Work around rustfmt giving up on a large expression

0cbbe56

Fix SLP vectorization test CHECK patterns

95ac567

fix: add min-llvm-version

0830a5a

external-rustc-drivers.md: some improvements

4956604

Merge pull request rust-lang#2756 from rust-lang/tshepang-patch-1

0e10f69

external-rustc-drivers.md: some style improvements

fix: remove space for tidy and only for x86_64

6176945

Fix missing unused_variables lint when using a match guard

5aba6b1

Within a binding pattern match guard, only real reads of a bound local impact its liveness analysis - not the fake read that is injected.

Update min-llvm-version: 22

8476e89

Co-authored-by: Nikita Popov <[email protected]>

Use rustc_parse's Recovery instead of a boolean

30ae46f

Pass Recovery down to rustc_parse's Parser

aef8217

clarity that the neon extension is present

bdd19d0

stabilize ptr_as_ref_unchecked

6490e0e

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2026

rust-bors bot merged commit 46c86ae into rust-lang:main Feb 3, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 3, 2026

jhpratt deleted the rollup-Kxb6k3Y branch February 3, 2026 07:57

This was referenced Feb 3, 2026

Remove HasDepContext by merging it into QueryContext #151968

Open

Rollup of 2 pull requests #152027

Closed

rust-bors bot mentioned this pull request Feb 3, 2026

Rename collect_active_jobs to several distinct names #151976

Merged

Kobzol mentioned this pull request Feb 3, 2026

Show largest job duration changes in hours and minutes in the post-merge report #152034

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #152025

Rollup of 11 pull requests #152025

Uh oh!

jhpratt commented Feb 3, 2026

Uh oh!

jhpratt commented Feb 3, 2026

Uh oh!

rust-bors bot commented Feb 3, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 3, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Feb 3, 2026

Uh oh!

rust-timer commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Uh oh!

Rollup of 11 pull requests #152025

Rollup of 11 pull requests #152025

Uh oh!

Conversation

jhpratt commented Feb 3, 2026

Uh oh!

jhpratt commented Feb 3, 2026

Uh oh!

rust-bors bot commented Feb 3, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 3, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 3, 2026

Uh oh!

rust-timer commented Feb 3, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants