-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Ignore all debuginfo tests for LLDB that we do not run in CI #152010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ignore all debuginfo tests for LLDB that we do not run in CI #152010
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
I haven’t checked that it actually works, but I think we already have an |
f479cb7 to
b441a5d
Compare
|
Yep, that works! |
b441a5d to
d978dd6
Compare
| @@ -1,4 +1,4 @@ | |||
| //@ min-lldb-version: 1800 | |||
| //@ ignore-lldb | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now using ignore-lldb for all cases, and found this case also.
|
Can we either put this in compiletest or leave an annotation for the ones that are lldb-version related? I expect we have some tests that are already ignored for other reasons on lldb and it would be nice to distinguish those cases, I think. |
|
I mean, the I'll add a comment. |
We only run LLDB 1500 in CI. Any test with a min-lldb-version above that is currently ignored. It's not clear any of these tests actually work with that LLDB version, and they definitely don't work on LLDB ~2100. So, ignore them until we fix debuginfo testing.
d978dd6 to
2b0cce0
Compare
We only run LLDB 1500 in CI. Any test with a min-lldb-version above that is currently ignored. It's not clear any of these tests actually work with that LLDB version, and they definitely don't work on LLDB ~2100. So, ignore them until we fix debuginfo testing.
Fixes #151966