Skip to content

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Jan 27, 2026

18 commits in efcd9f58636c1990393d495159045d9c35e43b8f..fe2f314aef06e688a9517da1ac0577bb1854d01f
2026-01-23 13:50:59 +0000 to 2026-01-30 21:52:01 +0000

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo weihanglo self-assigned this Jan 27, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

📌 Commit de883a5 has been approved by weihanglo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 28, 2026
Update cargo submodule

11 commits in efcd9f58636c1990393d495159045d9c35e43b8f..0f3a1e9099aecdf95f144e842d96dc1827c1985
2026-01-23 13:50:59 +0000 to 2026-01-27 20:14:45 +0000

- feat(lints): Add redundant_homepage lint  (rust-lang/cargo#16561)
- feat(lints): Add `non_*_case_features` (rust-lang/cargo#16560)
- Update build_std::basic test to ensure index doesn't update (rust-lang/cargo#16559)
- feat(lints): Add mutually exclusive `non_{kebab,snake}_case_packages` (rust-lang/cargo#16554)
- fix(lints): Pluralize non_kebab_case_bins (rust-lang/cargo#16553)
- Add -Z json-target-spec (rust-lang/cargo#16557)
- feat(lint): Add redundant_readme lint  (rust-lang/cargo#16552)
- chore(deps): update msrv (rust-lang/cargo#16387)
- tests: add regression test for --artifact-dir on stable (rust-lang/cargo#16541)
- Don't check the specific build-std output (rust-lang/cargo#16551)
- Fix build-std lto test to run on other platforms (rust-lang/cargo#16550)
@rust-log-analyzer

This comment has been minimized.

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

💔 Test for 06f9ae1 failed: CI. Failed job:

@weihanglo
Copy link
Member Author

[3775/3894] Linking CXX static library lib/libLLVMOptDriver.a
FAILED: [code=1] lib/libLLVMOptDriver.a 
: && "/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool" -static -no_warning_for_no_symbols -o lib/libLLVMOptDriver.a  tools/opt/CMakeFiles/LLVMOptDriver.dir/NewPMDriver.cpp.o tools/opt/CMakeFiles/LLVMOptDriver.dir/optdriver.cpp.o && cd /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/tools/opt && touch /Users/runner/work/rust/rust/build/x86_64-apple-darwin/llvm/build/./lib/libLLVMOptDriver.a
fatal error: /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: can't write to output file (Input/output error)
[3776/3894] Building CXX object tools/obj2yaml/CMakeFiles/obj2yaml.dir/xcoff2yaml.cpp.o
[3777/3894] Building CXX object tools/obj2yaml/CMakeFiles/obj2yaml.dir/wasm2yaml.cpp.o
ninja: build stopped: subcommand failed.

thread 'main' (97266) panicked at /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cmake-0.1.54/src/lib.rs:1119:5:

I don't think any relevance between Cargo submodule update and llvm build

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 29, 2026
Update cargo submodule

11 commits in efcd9f58636c1990393d495159045d9c35e43b8f..0f3a1e9099aecdf95f144e842d96dc1827c1985
2026-01-23 13:50:59 +0000 to 2026-01-27 20:14:45 +0000

- feat(lints): Add redundant_homepage lint  (rust-lang/cargo#16561)
- feat(lints): Add `non_*_case_features` (rust-lang/cargo#16560)
- Update build_std::basic test to ensure index doesn't update (rust-lang/cargo#16559)
- feat(lints): Add mutually exclusive `non_{kebab,snake}_case_packages` (rust-lang/cargo#16554)
- fix(lints): Pluralize non_kebab_case_bins (rust-lang/cargo#16553)
- Add -Z json-target-spec (rust-lang/cargo#16557)
- feat(lint): Add redundant_readme lint  (rust-lang/cargo#16552)
- chore(deps): update msrv (rust-lang/cargo#16387)
- tests: add regression test for --artifact-dir on stable (rust-lang/cargo#16541)
- Don't check the specific build-std output (rust-lang/cargo#16551)
- Fix build-std lto test to run on other platforms (rust-lang/cargo#16550)
@rust-log-analyzer

This comment has been minimized.

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 29, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 29, 2026

💔 Test for bdfa48c failed: CI. Failed job:

@Zalathar
Copy link
Member

also fixed tests/run-make-cargo/apple-slow-tls/rmake.rs
accordingly for the new `-Zjson-target-spec` requirement
@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 31, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2026
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@weihanglo
Copy link
Member Author

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 31, 2026
Update cargo submodule


try-job: aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

☀️ Try build successful (CI)
Build commit: 88b22aa (88b22aab30e68d4361c2ab197fe478089a6d426f, parent: a293cc4af8b26701c42738381c0c6f9d2ba881e0)

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

📌 Commit f7ffe31 has been approved by weihanglo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 31, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 31, 2026
Update cargo submodule

18 commits in efcd9f58636c1990393d495159045d9c35e43b8f..fe2f314aef06e688a9517da1ac0577bb1854d01f
2026-01-23 13:50:59 +0000 to 2026-01-30 21:52:01 +0000
- feat(lints): Add unused workspace dependency lint (rust-lang/cargo#16571)
- docs: Remove redundant homepage link (rust-lang/cargo#16572)
- refactor: Remove unused workspace dependencies (rust-lang/cargo#16573)
- Re-downgrade curl-sys (rust-lang/cargo#16570)
- docs(report): enhance man pages for `cargo report *` (rust-lang/cargo#16430)
- fix(lints): Refine redundant metadata lints (rust-lang/cargo#16564)
- Prevent `cargo init` in home directory (rust-lang/cargo#16566)
- feat(lints): Add redundant_homepage lint  (rust-lang/cargo#16561)
- feat(lints): Add `non_*_case_features` (rust-lang/cargo#16560)
- Update build_std::basic test to ensure index doesn't update (rust-lang/cargo#16559)
- feat(lints): Add mutually exclusive `non_{kebab,snake}_case_packages` (rust-lang/cargo#16554)
- fix(lints): Pluralize non_kebab_case_bins (rust-lang/cargo#16553)
- Add -Z json-target-spec (rust-lang/cargo#16557)
- feat(lint): Add redundant_readme lint  (rust-lang/cargo#16552)
- chore(deps): update msrv (rust-lang/cargo#16387)
- tests: add regression test for --artifact-dir on stable (rust-lang/cargo#16541)
- Don't check the specific build-std output (rust-lang/cargo#16551)
- Fix build-std lto test to run on other platforms (rust-lang/cargo#16550)
@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

💔 Test for 6573c44 failed: CI. Failed job:

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260123.484
Commit: 6bd6555ca37d84114959e1c76d2c01448ff61c5d
Build Date: 2026-01-23T19:41:17Z
Worker ID: {093c9c5a-12ce-42fa-a97a-189f5e8ded82}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS
---
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   4 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d

@weihanglo
Copy link
Member Author

I don't think it is related? denied: permission_denied: write_package

 7 warnings found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 92)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 97)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 48)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 61)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 64)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 75)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 83)
REPOSITORY                   TAG               IMAGE ID       CREATED        SIZE
ghcr.io/rust-lang/buildkit   buildx-stable-1   84af6b03465f   40 hours ago   235MB
rust-ci                      latest            a38f7a839e55   2 weeks ago    5.77GB
The push refers to repository [ghcr.io/rust-lang/rust-ci]
09fbbfce566c: Preparing
f9a73a2ff6bb: Preparing
09f62e8046fd: Preparing
512fecb1ef9c: Preparing
fc81b3d7aaf1: Preparing
dfa070b83179: Preparing
44f269c2c7be: Preparing
d1f74337e476: Preparing
65480fa4d971: Preparing
91b66c78ba8f: Preparing
fbb9bbbaf4d2: Preparing
dfa070b83179: Waiting
65480fa4d971: Waiting
44f269c2c7be: Waiting
d1f74337e476: Waiting
91b66c78ba8f: Waiting
fbb9bbbaf4d2: Waiting
512fecb1ef9c: Pushed
dfa070b83179: Pushed
09f62e8046fd: Pushed
44f269c2c7be: Pushed
09fbbfce566c: Pushed
65480fa4d971: Pushed
fbb9bbbaf4d2: Pushed
d1f74337e476: Pushed
f9a73a2ff6bb: Pushed
91b66c78ba8f: Pushed
denied: permission_denied: write_package

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 31, 2026

☀️ Test successful - CI
Approved by: weihanglo
Duration: 3h 7m 8s
Pushing 310ae8c to main...

@rust-bors rust-bors bot merged commit 310ae8c into rust-lang:main Jan 31, 2026
13 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 31, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 44e34e1 (parent) -> 310ae8c (this PR)

Test differences

Show 31 test diffs

Stage 2

  • artifact_dir::artifact_dir_rejected_on_stable: [missing] -> pass (J0)
  • cargo_init::in_home_directory::case: [missing] -> pass (J0)
  • cargo_report_future_incompat::help::case: [missing] -> pass (J0)
  • custom_target::custom_target_gated: [missing] -> pass (J0)
  • lints::non_kebab_case_bin::bin_name_explicit: pass -> [missing] (J0)
  • lints::non_kebab_case_bin::bin_name_from_package: pass -> [missing] (J0)
  • lints::non_kebab_case_bin::bin_name_from_path: pass -> [missing] (J0)
  • lints::non_kebab_case_bin::bin_name_from_script_name: ignore (-Zscript is unstable) -> [missing] (J0)
  • lints::non_kebab_case_bins::bin_name_explicit: [missing] -> pass (J0)
  • lints::non_kebab_case_bins::bin_name_from_package: [missing] -> pass (J0)
  • lints::non_kebab_case_bins::bin_name_from_path: [missing] -> pass (J0)
  • lints::non_kebab_case_bins::bin_name_from_script_name: [missing] -> ignore (-Zscript is unstable) (J0)
  • lints::non_kebab_case_features::feature_name_explicit: [missing] -> pass (J0)
  • lints::non_kebab_case_features::feature_name_implicit: [missing] -> pass (J0)
  • lints::non_kebab_case_packages::package_name_explicit: [missing] -> pass (J0)
  • lints::non_kebab_case_packages::package_name_from_script_name: [missing] -> ignore (-Zscript is unstable) (J0)
  • lints::non_snake_case_features::feature_name_explicit: [missing] -> pass (J0)
  • lints::non_snake_case_features::feature_name_implicit: [missing] -> pass (J0)
  • lints::non_snake_case_packages::package_name_explicit: [missing] -> pass (J0)
  • lints::non_snake_case_packages::package_name_from_script_name: [missing] -> ignore (-Zscript is unstable) (J0)
  • lints::redundant_homepage::inherited: [missing] -> pass (J0)
  • lints::redundant_homepage::with_docs: [missing] -> pass (J0)
  • lints::redundant_homepage::with_repo: [missing] -> pass (J0)
  • lints::redundant_readme::custom_location: [missing] -> pass (J0)
  • lints::redundant_readme::custom_name: [missing] -> pass (J0)
  • lints::redundant_readme::explicit_readme: [missing] -> pass (J0)
  • lints::redundant_readme::implicit_readme: [missing] -> pass (J0)
  • lints::redundant_readme::inherited: [missing] -> pass (J0)
  • lints::unused_workspace_dependencies::unused: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 310ae8ca77f652e1458735062c9509d53123860f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 5651.8s -> 3310.3s (-41.4%)
  2. pr-check-1: 2064.0s -> 1611.6s (-21.9%)
  3. i686-gnu-2: 6084.3s -> 5052.4s (-17.0%)
  4. pr-check-2: 2625.4s -> 2219.1s (-15.5%)
  5. aarch64-apple: 10098.7s -> 8567.0s (-15.2%)
  6. aarch64-gnu-debug: 4584.9s -> 3990.8s (-13.0%)
  7. x86_64-gnu-tools: 3818.7s -> 3361.0s (-12.0%)
  8. x86_64-gnu-miri: 4893.4s -> 4362.4s (-10.9%)
  9. x86_64-msvc-ext1: 7446.1s -> 8188.0s (+10.0%)
  10. dist-x86_64-illumos: 5893.7s -> 6470.5s (+9.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (310ae8c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.1% [1.9%, 4.3%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.1% [1.9%, 4.3%] 2

Cycles

Results (primary 2.5%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.436s -> 474.479s (0.01%)
Artifact size: 397.79 MiB -> 397.88 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants