Skip to content

Replace "error" references in incremental compilation warnings #151385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssg wants to merge 1 commit into from
+5 −5
Closed

Replace "error" references in incremental compilation warnings #151385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions compiler/rustc_incremental/messages.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ incremental_cargo_help_2 =
the entire build directory can be changed to a different filesystem by setting the environment variable CARGO_TARGET_DIR to a different path (see https://doc.rust-lang.org/cargo/reference/config.html#buildtarget-dir)

incremental_copy_workproduct_to_cache =
error copying object file `{$from}` to incremental directory as `{$to}`: {$err}
failed to copy object file `{$from}` to incremental directory as `{$to}`: {$err}

incremental_corrupt_file = corrupt incremental compilation artifact found at `{$path}`. This file will automatically be ignored and deleted. If you see this message repeatedly or can provoke it without manually manipulating the compiler's artifacts, please file an issue. The incremental compilation system relies on hardlinks and filesystem locks behaving correctly, and may not deal well with OS crashes, so whatever information you can provide about your filesystem or other state may be very relevant.

Expand All @@ -32,21 +32,21 @@ incremental_create_lock =
incremental compilation: could not create session directory lock file: {$lock_err}
incremental_create_new = failed to create {$name} at `{$path}`: {$err}

incremental_delete_full = error deleting incremental compilation session directory `{$path}`: {$err}
incremental_delete_full = failed to delete incremental compilation session directory `{$path}`: {$err}

incremental_delete_incompatible =
failed to delete invalidated or incompatible incremental compilation session directory contents `{$path}`: {$err}

incremental_delete_lock =
error deleting lock file for incremental compilation session directory `{$path}`: {$err}
failed to delete lock file for incremental compilation session directory `{$path}`: {$err}

incremental_delete_old = unable to delete old {$name} at `{$path}`: {$err}

incremental_delete_partial = failed to delete partly initialized session dir `{$path}`: {$err}

incremental_delete_workproduct = file-system error deleting outdated file `{$path}`: {$err}
incremental_delete_workproduct = file-system failed to delete outdated file `{$path}`: {$err}
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "file-system failed to delete" is grammatically incorrect. It should be "failed to delete" (consistent with other changes in this PR) or "file-system error deleting" (original). The current wording combines parts of both in an awkward way.

Suggested change
incremental_delete_workproduct = file-system failed to delete outdated file `{$path}`: {$err}
incremental_delete_workproduct = failed to delete outdated file `{$path}`: {$err}

Copilot uses AI. Check for mistakes.

incremental_finalize = error finalizing incremental compilation session directory `{$path}`: {$err}
incremental_finalize = failed to finalize incremental compilation session directory `{$path}`: {$err}

incremental_finalized_gc_failed =
failed to garbage collect finalized incremental compilation session directory `{$path}`: {$err}
Expand Down
Loading