v0 mangling for std on nightly

[davidtwco]

Following #89917 and rust-lang/compiler-team#938, it doesn't make sense that std for these channels would have legacy mangling while the user's code would use v0.

r? @Kobzol

[rustbot]

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

[Kobzol]

Makes sense, thanks! Prioritizing slightly since it still might get into today's nightly (although I worry some tests might fail..).

@bors r+ p=1

[bors]

📌 Commit 5e4a05f has been approved by Kobzol

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5e4a05f with merge 06596c0...

[rust-log-analyzer]

The job x86_64-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/sanitizer/dataflow.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/sanitizer/dataflow.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zsanitizer=dataflow" "-Zsanitizer-dataflow-abilist=/checkout/tests/ui/sanitizer/dataflow-abilist.txt" "-C" "unsafe-allow-abi-mismatch=sanitizer"
stdout: none
--- stderr -------------------------------
error: linking with `cc` failed: exit status: 1
   |
   = note:  "cc" "-m64" "/tmp/rustcX99GJO/symbols.o" "-Wl,-Bstatic" "-Wl,--whole-archive" "-Wl,<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc-nightly_rt.dfsan.a" "-Wl,--no-whole-archive" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-231135333275c1cf.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcX99GJO/raw-dylibs" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-B<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld" "-fuse-ld=lld" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs" "-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib,--enable-new-dtags,-z,origin"
   = note: some arguments are omitted. use `--verbose` to show all linker arguments
   = note: rust-lld: error: undefined symbol: core::panicking::assert_failed_inner (.dfsan)
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(core::panicking::assert_failed::<u8, u8> (.dfsan))
           
           rust-lld: error: undefined symbol: core::panicking::assert_failed::<i32, i32> (.dfsan)
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(dataflow::main (.dfsan))
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(dataflow::main (.dfsan))
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(dataflow::main (.dfsan))
           >>> referenced 1 more times
           
           rust-lld: error: undefined symbol: <u8 as core::fmt::Display>::fmt (.dfsan)
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(<&u8 as core::fmt::Debug>::fmt (.dfsan))
           
           rust-lld: error: undefined symbol: <u8 as core::fmt::LowerHex>::fmt (.dfsan)
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(<&u8 as core::fmt::Debug>::fmt (.dfsan))
           
           rust-lld: error: undefined symbol: <u8 as core::fmt::UpperHex>::fmt (.dfsan)
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(<&u8 as core::fmt::Debug>::fmt (.dfsan))
           
           rust-lld: error: undefined symbol: std::rt::lang_start_internal (.dfsan)
           >>> referenced by dataflow.a934cfd234e75439-cgu.0
           >>>               /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/dataflow/a.dataflow.a934cfd234e75439-cgu.0.rcgu.o:(main)
           collect2: error: ld returned 1 exit status
           

error: aborting due to 1 previous error
------------------------------------------

[bors]

💔 Test failed - checks-actions

[Kobzol]

Let's perf this in the meantime.

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 70ed8a5 (70ed8a5c71bbc001f48c2ff53905d9ba4b418d22, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

[rust-timer]

Finished benchmarking commit (70ed8a5): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.7%, 0.8%]	4
Regressions ❌ (secondary)	0.5%	[0.3%, 0.8%]	15
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.7%, 0.8%]	4

Max RSS (memory usage)

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.3%, secondary -6.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-6.0%	[-6.0%, -6.0%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

Results (primary 1.2%, secondary 5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[0.5%, 10.5%]	35
Regressions ❌ (secondary)	6.2%	[0.0%, 10.5%]	90
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	47
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	20
All ❌✅ (primary)	1.2%	[-0.1%, 10.5%]	82

Bootstrap: 473.456s -> 472.364s (-0.23%)
Artifact size: 388.90 MiB -> 389.49 MiB (0.15%)

[Kobzol]

3% larger stdlib. Slightly annoying, but not a big deal, I think. #145343 might reduce that size considerably, once I can finally get back to it someday.. :D