Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 17, 2025

Working on #148648 and realized that we actually didn't test for enum variants reexports, so here we are.

I also think I'll do #148648 at the same time as #148547.

r? @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 17, 2025
@Kobzol
Copy link
Member

Kobzol commented Nov 17, 2025

@rust-timer queue

(Just testing perfbot).

@lolbinarycat
Copy link
Contributor

lolbinarycat commented Nov 17, 2025

The filename and comment for the new file seem quite broad, but as far as I know enum variants are the only associated items that can be reexported, so maybe that should be changed to reflect the narrowness of the test?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025
@GuillaumeGomez GuillaumeGomez force-pushed the test-for-reexported-variant branch from 8f6c986 to 2afc11c Compare November 17, 2025 21:09
@GuillaumeGomez
Copy link
Member Author

The filename and comment for the new file seem quite broad, but as far as I know enum variants are the only associated items that can be reexported, so maybe that should be changed to reflect the narrowness of the test?

Agreed. When I originally made the file, I thought we could reexport impl associated items. Discovered (again) that it's not possible.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2025
@lolbinarycat
Copy link
Contributor

That's funny, I also rediscovered you can't reexport associated items in the process of reviewing this PR.

I think the current file comment is ok, but could be better, maybe something like "tests that reexported enum variants correctly link to the original variant" or something.

you can r=me with or without the new comment once CI is green.

@GuillaumeGomez GuillaumeGomez force-pushed the test-for-reexported-variant branch from 2afc11c to db72a2d Compare November 18, 2025 10:11
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the test-for-reexported-variant branch from db72a2d to 8642d82 Compare November 18, 2025 11:23
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez
Copy link
Member Author

@bors r=lolbinarycat rollup

@bors
Copy link
Collaborator

bors commented Nov 18, 2025

📌 Commit 8642d82 has been approved by lolbinarycat

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
bors added a commit that referenced this pull request Nov 18, 2025
Rollup of 4 pull requests

Successful merges:

 - #148970 (std: sys: fs: uefi: Implement stat)
 - #149020 (flush_delayed: add note about stashed diagnostics)
 - #149026 (Add test for href of reexported enum variant)
 - #149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1fd16b1 into rust-lang:main Nov 18, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 18, 2025
rust-timer added a commit that referenced this pull request Nov 18, 2025
Rollup merge of #149026 - GuillaumeGomez:test-for-reexported-variant, r=lolbinarycat

Add test for href of reexported enum variant

Working on #148648 and realized that we actually didn't test for enum variants reexports, so here we are.

I also think I'll do #148648 at the same time as #148547.

r? `@lolbinarycat`
@GuillaumeGomez GuillaumeGomez deleted the test-for-reexported-variant branch November 18, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants