-
Notifications
You must be signed in to change notification settings - Fork 14k
Add test for href of reexported enum variant #149026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for href of reexported enum variant #149026
Conversation
|
@rust-timer queue (Just testing perfbot). |
|
The filename and comment for the new file seem quite broad, but as far as I know enum variants are the only associated items that can be reexported, so maybe that should be changed to reflect the narrowness of the test? @rustbot author |
8f6c986 to
2afc11c
Compare
Agreed. When I originally made the file, I thought we could reexport @rustbot ready |
|
That's funny, I also rediscovered you can't reexport associated items in the process of reviewing this PR. I think the current file comment is ok, but could be better, maybe something like "tests that reexported enum variants correctly link to the original variant" or something. you can r=me with or without the new comment once CI is green. |
2afc11c to
db72a2d
Compare
This comment has been minimized.
This comment has been minimized.
db72a2d to
8642d82
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=lolbinarycat rollup |
Rollup of 4 pull requests Successful merges: - #148970 (std: sys: fs: uefi: Implement stat) - #149020 (flush_delayed: add note about stashed diagnostics) - #149026 (Add test for href of reexported enum variant) - #149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #149026 - GuillaumeGomez:test-for-reexported-variant, r=lolbinarycat Add test for href of reexported enum variant Working on #148648 and realized that we actually didn't test for enum variants reexports, so here we are. I also think I'll do #148648 at the same time as #148547. r? `@lolbinarycat`
Working on #148648 and realized that we actually didn't test for enum variants reexports, so here we are.
I also think I'll do #148648 at the same time as #148547.
r? @lolbinarycat