Skip to content

Conversation

@Rohithkumar2030
Copy link

Summary

This PR fixes an internal compiler error (ICE) occurring when matching a deref pattern inside a const block.

Changes made

  • Adjusted logic in rustc_hir_typeck from 'span_bug' to 'span_delayed_bug'
  • Added a test: tests/ui/pattern/deref-patterns/ice-adjust-mode-unimplemented-for-constblock.rs
  • Generated the corresponding .stderr file for the test using ./x test tests/ui/pattern/deref-patterns/ice-adjust-mode-unimplemented-for-constblock.rs --bless

Notes

  • Verified locally with ./x test tidy
  • Open for review and feedback

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@lcnr
Copy link
Contributor

lcnr commented Nov 12, 2025

This ICE is intentional as the feature is not implemented yet.

Also, you have to use ./x.py test to test whether added UI tests are correct, not only tidy.

I don't think fixing this ICE is worth unless it also triggers if the feature is not enabled.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 12, 2025

Closing with same rationale as #148876 (comment)

@oli-obk oli-obk closed this Nov 12, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants