Undo CopyForDeref assertion in const qualif #147764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
rustbot
added
S-waiting-on-review
Collaborator
Contributor
|
r? saethlin (since you reviewed the original PR) |
Member
|
What kind of MIR does const_checks get run on, if it's not runtime MIR? |
Contributor
Author
|
It runs on post-cleanup analysis MIR right here right before the lowering to runtime MIR. |
Member
|
Hm. I'm a bit wary of how we got this wrong, but at least now we have a test case. @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Oct 17, 2025
…hlin Undo CopyForDeref assertion in const qualif Fixes rust-lang#147733 caused by rust-lang#145513 This code in fact does not run only on runtime MIR.
bors
added a commit
that referenced
this pull request
Oct 17, 2025
Rollup of 6 pull requests Successful merges: - #144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce) - #147468 (Implement fs api set_times and set_times_nofollow) - #147660 (rustdoc-search: stringdex 0.0.2) - #147735 (Micro-optimization in `FunctionCx::initialize_locals`) - #147764 (Undo CopyForDeref assertion in const qualif) - #147783 (bootstrap: migrate to object 0.37) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Oct 18, 2025
Rollup of 8 pull requests Successful merges: - #140153 (Implement `Debug` for `EncodeWide`) - #145724 (the `#[track_caller]` shim should not inherit `#[no_mangle]`) - #147258 (iter repeat: panic on last) - #147454 (Fix backtraces with `-C panic=abort` on qnx; emit unwind tables by default) - #147468 (Implement fs api set_times and set_times_nofollow) - #147764 (Undo CopyForDeref assertion in const qualif) - #147805 (use module_child index as disambiguator for external items) - #147824 (docs: update Motor OS target docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 18, 2025
Kobzol
pushed a commit
to Kobzol/rustc_codegen_cranelift
that referenced
this pull request
Dec 29, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#140153 (Implement `Debug` for `EncodeWide`) - rust-lang/rust#145724 (the `#[track_caller]` shim should not inherit `#[no_mangle]`) - rust-lang/rust#147258 (iter repeat: panic on last) - rust-lang/rust#147454 (Fix backtraces with `-C panic=abort` on qnx; emit unwind tables by default) - rust-lang/rust#147468 (Implement fs api set_times and set_times_nofollow) - rust-lang/rust#147764 (Undo CopyForDeref assertion in const qualif) - rust-lang/rust#147805 (use module_child index as disambiguator for external items) - rust-lang/rust#147824 (docs: update Motor OS target docs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147733 caused by #145513
This code in fact does not run only on runtime MIR.