Make macOS dist build configuration match where reasonable #145883
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
|
@bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple |
rust-bors bot
added a commit
that referenced
this pull request
Aug 26, 2025
Make macOS dist build configuration match where reasonable try-job: dist-aarch64-apple try-job: dist-x86_64-apple
This comment has been minimized.
This comment has been minimized.
|
💥 Test timed out after |
|
@bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple |
rust-bors bot
added a commit
that referenced
this pull request
Sep 4, 2025
Make macOS dist build configuration match where reasonable try-job: dist-aarch64-apple try-job: dist-x86_64-apple
This comment has been minimized.
This comment has been minimized.
madsmtm
approved these changes
Sep 4, 2025
🤷 @bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 5, 2025
Make macOS dist build configuration match where reasonable try-job: dist-aarch64-apple try-job: dist-x86_64-apple
|
☔ The latest upstream changes (presumably #146513) made this pull request unmergeable. Please resolve the merge conflicts. |
shepmaster
force-pushed
the
unify-macos-ci
branch
from
0bcde87 to
5df0be3
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 29, 2025
Make macOS dist build configuration match where reasonable try-job: dist-aarch64-apple try-job: dist-x86_64-apple
|
Before: This code, after running a second time to warm the cache... 🥁 🥁 🥁 Seems reasonable to me! |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 30, 2025
Rollup of 4 pull requests Successful merges: - #145883 (Make macOS dist build configuration match where reasonable) - #146457 (Skip cleanups on unsupported targets) - #147152 (builtin `Fn`-trait impls: instantiate binder before the return type `Sized` check) - #147153 ([rustdoc] Move doc cfg propagation pass before items stripping passes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 30, 2025
Rollup merge of #145883 - shepmaster:unify-macos-ci, r=madsmtm Make macOS dist build configuration match where reasonable r? `@madsmtm`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @madsmtm