Clippy subtree update #143745

flip1995 · 2025-07-10T18:27:39Z

Cargo.lock update due to ui_test bump and restructure.

The `TyCtxt::hir_get_fn_id_for_return_block()` function was too broad, as it will return positively even when given part of an expression that can be used as a return value. A new `potential_return_of_enclosing_body()` utility function has been made to represent the fact that an expression might be directly returned from its enclosing body.

This commit also adds more test cases, which work fine but were mentioned in the issue.

…links-expansion, r=lolbinarycat [rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion Fixes rust-lang#141553. The problem was that we change the context for the attributes in some cases to get better error output, preventing us to detect if the attribute comes from expansion. Most of the changes are about keeping track of the "does this span comes from expansion" information. r? ```@Manishearth```

The lint was extra restrictive, and didn't suggest using `core::ptr::null` and `core::ptr::null_mut` in `const` contexts although they have been const-stabilized since Rust 1.24.

…ubtree-update

…=fee1-dead New const traits syntax This PR only affects the AST and doesn't actually change anything semantically. All occurrences of `~const` outside of libcore have been replaced by `[const]`. Within libcore we have to wait for rustfmt to be bumped in the bootstrap compiler. This will happen "automatically" (when rustfmt is run) during the bootstrap bump, as rustfmt converts `~const` into `[const]`. After this we can remove the `~const` support from the parser Caveat discovered during impl: there is no legacy bare trait object recovery for `[const] Trait` as that snippet in type position goes down the slice /array parsing code and will error r? ``@fee1-dead`` cc ``@nikomatsakis`` ``@traviscross`` ``@compiler-errors``

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#139858 (New const traits syntax) - rust-lang#140809 (Reduce special casing for the panic runtime) - rust-lang#142730 (suggest declaring modules when file found but module not defined) - rust-lang#142806 (Normalize before computing ConstArgHasType goal in new solver) - rust-lang#143046 (const validation: properly ignore zero-sized UnsafeCell) - rust-lang#143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology) - rust-lang#143096 (tag_for_variant: properly pass TypingEnv) - rust-lang#143104 (hir_analysis: prohibit `dyn PointeeSized`) - rust-lang#143106 (gce: don't ICE on non-local const) Failed merges: - rust-lang#143036 (Remove support for `dyn*` from the compiler) r? `@ghost` `@rustbot` modify labels: rollup

@rustbot

The lint was extra restrictive, and didn't suggest using `core::ptr::null` and `core::ptr::null_mut` in `const` contexts although they have been const-stabilized since Rust 1.24. changelog: [`zero_ptr`]: lint in `const` context as well @rustbot label +I-false-negative +C-bug

…15123) Closes rust-lang/rust-clippy#15116 The cause for this issue is that `_` belongs to the `Common` catagory in unicode instead of `Latin` like other ASCII alphabets. Since ASCII characters are always allowed, I just added an extra `is_ascii()` check to ensure this. changelog: [`disallowed_script_idents`] fix FP on identifiers with `_`

fix: check against 'main' function name instead of entrypoint function

fixes https://github.com/rust-lang/rust-clippy/actions/runs/16126736130/job/45505355614?pr=15222#logs

Full list of `impl const Default` types: - () - bool - char - Cell - std::ascii::Char - usize - u8 - u16 - u32 - u64 - u128 - i8 - i16 - i32 - i64 - i128 - f16 - f32 - f64 - f128 - std::marker::PhantomData<T> - Option<T> - std::iter::Empty<T> - std::ptr::Alignment - &[T] - &mut [T] - &str - &mut str - String - Vec<T>

@sesgoe

changelog: [`exit`]: When using the `--test` or `--all-targets` flag, the exit lint should not fail on the main function. Fixes rust-lang/rust-clippy#13518 With help from @sesgoe

@Kobzol

Previously rust-lang/triagebot#1985 After a lintcheck run a comment will be created in the PR thread with an overview of the changes, example here Alexendoo/rust-clippy#18 (comment) (plus the normal GHA debugging experience) It will only comment if there are some changes, if there's already an existing comment it will be updated for each run Similar to https://github.com/rust-lang/team/blob/master/.github/workflows/dry-run.yml The PR number is supplied by the lintcheck run, so technically someone could forge it to be annoying and edit the summaries in other threads, but that is pretty low impact and easy to deal with. There is a `pull_requests` field on the event but as @Kobzol [pointed out to me](rust-lang/triagebot#1985 (comment)) it's not populated for PRs from forks r? @flip1995 changelog: none

I think it's pretty common for a lint to be proposed for clippy only for consensus to be it belongs in rustc, and additionally sometimes bugs get filed here when the fault is actually with rustc. https://forge.rust-lang.org/triagebot/transfer.html#issue-transfer changelog: none

Propose to replace `x.map_or(false, |y| y == z)` by `x == Some(z)` only if `x` is not adjusted. Otherwise, the type of `x` in the comparaison may not be the expected one, as it may be the product of an auto-deref. changelog: [`unnecessary_map_or`]: do not propose to replace the `map_or` call by a comparaison if types wouldn't be correct Fixes rust-lang/rust-clippy#15180

When comparing `x.map(func) == Some(bool_lit)`, the value of `bool_lit` was ignored, despite the fact that its value should determine the value of the proposed expression. `func` can be either a closure or a path. For the latter, η-expansion will be used if needed to invert the result of the function call. changelog: [`manual_is_variant_and`]: fix inverted suggestions that could lead to code with different semantics Fixes rust-lang/rust-clippy#15202   ### Summary Notes - [Beta-nomination](rust-lang/rust-clippy#15206 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details*

Closes rust-lang/rust-clippy#15063 ---- changelog: [`op_ref`]: fix wrongly showed macro definition in suggestions changelog: [`needless_bool_assign`]: fix missing curlies when on else if

@ghost

r? @ghost changelog: none

…ubtree-update

rustbot · 2025-07-10T18:27:46Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

flip1995 · 2025-07-10T18:36:29Z

Cargo.toml

@@ -12,6 +12,7 @@ members = [
  "src/tools/bump-stage0",
  "src/tools/cargotest",
  "src/tools/clippy",
+  "src/tools/clippy/clippy_test_deps",


@RalfJung I added this to the Cargo.toml to make the tests pass. Is this correct?

Hm, that seems odd, I don't think we did that for Miri. It should probably be excluded from the workspace, so that it can have its own lockfile checked in.

But for Miri we didn't have to manually exclude anything.

Ok, I'll look into this tomorrow. Does miri have a Cargo.lock file checked in?

For the deps, yes: https://github.com/rust-lang/rust/tree/master/src/tools/miri/test_dependencies.

Miri itself is part of the cargo workspace so it uses the big lockfile in the root, when it is built via ./x. The lockfile in src/tools/miri only exists because it is synced from the subrepo, and is only used for subrepo builds.

Alexendoo and others added 30 commits May 16, 2025 01:07

Create summary comment for lintcheck runs

2dbaf1c

triagebot: enable issue transfer

8bb957e

Correct the CC lint's documentation

709efc2

Fix coerce_container_to_any false positive on autoderef

a2b2345

Use precedence-aware formatting for coerce_container_to_any suggestions

8e285d6

Fix reference mutability in coerce_container_to_any diagnostics

dc1b9ce

fix: op_ref wrongly showed macro definition in suggestions

f46cf87

fix: needless_bool_assign missing curlies when on else if

f29aa69

precommit test

dc3b8be

or_fun_call: lint Option/Result::and(_then) too

a82c142

Update clippy source code to changes on source_span_for_markdown_range

7a6f7bc

Handle potentially-shadowing bindings in manual_let_else

cd68244

This commit also adds more test cases, which work fine but were mentioned in the issue.

fix mul_add uncertain sugg

71ff9a0

add more test cases and clauses

1eb2920

Reduce page size and number of DOM elements on clippy lints page

ecb397a

fix closure and refactor tooling code

0c0a4d5

fix redudant closure broken fix

9b4231d

Don't remove explicit cast to trait object pointer

bb59c39

Change const trait bound syntax from ~const to [const]

4f3c174

doc_nested_refdefs: do not falsely report checkboxes as refdefs

664b143

zero_ptr: lint in const context as well

9117cb0

The lint was extra restrictive, and didn't suggest using `core::ptr::null` and `core::ptr::null_mut` in `const` contexts although they have been const-stabilized since Rust 1.24.

Merge commit 'c5dbd1de07e0407b9687619a868384d6de06253f' into clippy-s…

074ccaf

…ubtree-update

broken_links: Fix rustdoc API usage

4a8eec3

fix: disallowed_script_idents FP on identifiers with _

7e406e2

Jared-Prime and others added 17 commits July 7, 2025 15:56

Merge pull request rust-lang#1 from sesgoe/ses/update-clippy-fix-13518

52aa383

fix: check against 'main' function name instead of entrypoint function

do not completely suppress warning with test code

1c7fb0f

remove no longer used import

9580d61

use preinterned symbol

81dd4e6

fixes https://github.com/rust-lang/rust-clippy/actions/runs/16126736130/job/45505355614?pr=15222#logs

Account for const stability in clippy when checking constness

5228e28

skip exit late lint pass on tests (rust-lang#15222)

d964e55

changelog: [`exit`]: When using the `--test` or `--all-targets` flag, the exit lint should not fail on the main function. Fixes rust-lang/rust-clippy#13518 With help from @sesgoe

Fix multiple problems in rust-lang#15063 (rust-lang#15070)

49ca220

Closes rust-lang/rust-clippy#15063 ---- changelog: [`op_ref`]: fix wrongly showed macro definition in suggestions changelog: [`needless_bool_assign`]: fix missing curlies when on else if

Remove uncessary parens in closure body with unused lint

0a64bfd

Merge remote-tracking branch 'upstream/master' into rustup

9e0f749

Bump nightly version -> 2025-07-10

b9af667

Rustup (rust-lang#15243)

cdbbf3a

r? @ghost changelog: none

Merge commit 'cdbbf3afda0b1bf51568b368f629b1d828507f98' into clippy-s…

ee400af

…ubtree-update

rustbot assigned Manishearth Jul 10, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2025

Update Cargo.lock

69fca56

flip1995 force-pushed the clippy-subtree-update branch from f1dca6b to 69fca56 Compare July 10, 2025 18:34

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 10, 2025

flip1995 commented Jul 10, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Add clippy_test_deps to workspace member of repo

c629a45

flip1995 force-pushed the clippy-subtree-update branch from 988bba3 to c629a45 Compare July 10, 2025 18:45

flip1995 marked this pull request as draft July 10, 2025 20:05

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clippy subtree update #143745

Clippy subtree update #143745

Uh oh!

flip1995 commented Jul 10, 2025 •

edited

Loading

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

flip1995 Jul 10, 2025

Uh oh!

RalfJung Jul 10, 2025

Uh oh!

RalfJung Jul 10, 2025

Uh oh!

flip1995 Jul 10, 2025

Uh oh!

RalfJung Jul 10, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Clippy subtree update #143745

Are you sure you want to change the base?

Clippy subtree update #143745

Uh oh!

Conversation

flip1995 commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 10, 2025

Uh oh!

flip1995 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

flip1995 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

flip1995 commented Jul 10, 2025 •

edited

Loading