[rustdoc] Display unsafe attrs with edition 2024 unsafe() wrappers.

[obi1kenobi]

Use Rust 2024 edition representation for unsafe attributes in rustdoc JSON and HTML:

• #[no_mangle] -> #[unsafe(no_mangle)]
• #[export_name = "foo"] -> #[unsafe(export_name = "foo")]
• #[link_section = ".text"] -> #[unsafe(link_section = ".text")]

The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that unsafe() wasn't always necessary) in order to understand a crate's documentation.

After some looking through the T-rustdoc issues, I was not able to find an existing issue for this. Apologies if I missed it.

r? @aDotInTheVoid

[rustbot]

aDotInTheVoid is currently at their maximum review capacity.
They may take a while to respond.

[rustbot]

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

• It's intentional.
• The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

[aDotInTheVoid]

#142936 is likely to merge before this, as this requires a FCP for UI changes. Therefore all the rustdoc-json changes are likely to go away here.

@rfcbot fcp merge

[obi1kenobi]

Not an issue, thanks for the heads-up.

[aDotInTheVoid]

@rfcbot fcp cancel

[rfcbot]

@aDotInTheVoid proposal cancelled.

[aDotInTheVoid]

@rfcbot fcp merge

(accidentally FCP’d to full T-Rustdoc, not T-Rustdoc-Frontend 💀)

[aDotInTheVoid]

@rust-lang/rustdoc-frontend can someone start an FCP on this?

[GuillaumeGomez]

Sounds like a good idea!

@aDotInTheVoid normally with only the t-rustdoc-frontend tag, you were good to go. 😉

EDIT: Ah no, just learned that you need o be part of the (sub-)team to do that, my bad.

@rfcbot fcp merge

[rfcbot]

Team member @GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members:

• @GuillaumeGomez
• @camelid
• @jsha
• @notriddle

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.