-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix(keyword_docs.rs): use of as
keyword to disambiguate paths
#143098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@fmease I hadn't noticed, that's bad luck. From what I can tell this fix seems more complete and quite different content. I don't know what's the best path forward. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
can you squash these commits, given that most of them are related fixups |
@tshepang yes. Is that okay? (should be a single commit now.) |
Please give this PR a description that summarizes what happens here. "I fixed something in that file" is not super helpful :) Please mention at least the 'as' keyword. |
as
keyword to disambiguate paths
@RalfJung thanks, sorry about that. Is now fine or still not ideal? I changed both description and title. |
as
keyword to disambiguate pathsas
keyword to disambiguate paths
So I wrote the other PR. My opinion of resolving this conflict would be to treat my contribution as the textual description of how this syntax works and this as a detailed example. My doc goes into some depth on when you actually want to use this syntax and provides a (slightly bad) real-world example. This PR offers a more detailed, but contrived example. These combined I think can harmonize quite well. |
Also, would it make more sense to illustrate this concept with a macro definition than a simple method call? Macros are probably a more practical and common use case than actually disambiguating an associated item. Granted, macros bring in a bunch of conceptual overhead that might not be desirable. |
keyword_docs.rs
was missing documenting the use of theas
keyword to disambiguate paths in trait implementations.This is also described in the issue linked below.
There isn't a tracking issue, but there is an issue here.
Some details:
for
docs