Add windows-gnullvm hosts to the manifest #143031
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
mati865
force-pushed
the
push-mutywntmvomx
branch
from
e7a5863 to
508021a
Compare
|
Well. I am going to nominate this for beta and let people decide it's not worth the trouble. |
workingjubilee
added
beta-nominated
Mark-Simulacrum
added
beta-accepted
|
@bors r+ I'm going to go ahead and reject the backport since we don't normally backport features (and this is one). We should really figure out a way to make it much harder to miss updating this file though... |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 28, 2025
…Simulacrum Add windows-gnullvm hosts to the manifest I made a mistake testing rust-lang#140772 only with `rustup-toolchain-install-master` which doesn't care about the manifests. This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake testing #140772 only with
rustup-toolchain-install-masterwhich doesn't care about the manifests.This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.