Detect missing derive on unresolved attribute even when not imported

[estebank]

When encountering unresolved attributes, ensure the proc-macros for every crate in scope are added to the macro_map so that typos and missing derives are properly detected.

error: cannot find attribute `sede` in this scope
  --> $DIR/missing-derive-3.rs:20:7
   |
LL |     #[sede(untagged)]
   |       ^^^^
   |
help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute
   |
LL |     #[serde(untagged)]
   |         +

error: cannot find attribute `serde` in this scope
  --> $DIR/missing-derive-3.rs:14:7
   |
LL |     #[serde(untagged)]
   |       ^^^^^
   |
note: `serde` is imported here, but it is a crate, not an attribute
  --> $DIR/missing-derive-3.rs:4:1
   |
LL | extern crate serde;
   | ^^^^^^^^^^^^^^^^^^^
help: `serde` is an attribute that can be used by the derive macros `Deserialize` and `Serialize`, you might be missing a `derive` attribute
   |
LL + #[derive(Deserialize, Serialize)]
LL | enum B {
   |

Follow up to #134841.

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jieyouxu]

r? compiler

[compiler-errors]

This needs a perf run firstly I think

@bors try parent=855e0fe46e68d94e9f6147531b75ac2d488c548e @rust-timer queue

[compiler-errors]

ugh, that will fail because bors1 doesn't know parents. I meant:

@bors2 try parent=855e0fe46e68d94e9f6147531b75ac2d488c548e @rust-timer queue

[rust-bors]

⌛ Trying commit d617a5b with merge 07b2f21…

To cancel the try build, run the command @bors2 try cancel.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout serde-attr-5 (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self serde-attr-5 --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging compiler/rustc_resolve/src/lib.rs
CONFLICT (content): Merge conflict in compiler/rustc_resolve/src/lib.rs
Auto-merging compiler/rustc_resolve/src/diagnostics.rs
CONFLICT (content): Merge conflict in compiler/rustc_resolve/src/diagnostics.rs
Auto-merging compiler/rustc_resolve/src/build_reduced_graph.rs
Automatic merge failed; fix conflicts and then commit the result.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 07b2f21 (07b2f218801fa85db469fc131c97d08b0a40e9b9, parent: 855e0fe46e68d94e9f6147531b75ac2d488c548e)

[rust-timer]

Finished benchmarking commit (07b2f21): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.5%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.2%	[-6.2%, -6.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.3%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.1%, 2.4%]	2
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	2.3%	[2.1%, 2.4%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.604s -> 465.331s (0.16%)
Artifact size: 374.58 MiB -> 374.59 MiB (0.00%)