Skip to content

Fix handling of LoongArch target features not supported by LLVM 19 #140460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix handling of LoongArch target features not supported by LLVM 19 #140460

wants to merge 3 commits into from
+25 −18

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Apr 29, 2025

Fixes #140455

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025
@Urgau
Copy link
Member

Urgau commented Apr 29, 2025

r? Urgau @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 29, 2025

📌 Commit 74b55b4 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge of rust-lang#140460 - heiher:issue-140455, r=Urgau
bd29df2 
Fix handling of LoongArch target features not supported by LLVM 19

Fixes rust-lang#140455
@Zalathar Zalathar mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge of rust-lang#140501 - Zalathar:rollup-86sqqur, r=Zalathar
c639c67 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#140380 (transmutability: uninit transition matches unit byte only)
 - rust-lang#140385 (Subtree update of `rust-analyzer`)
 - rust-lang#140395 (organize and extend forbidden target feature tests)
 - rust-lang#140430 (Improve test coverage of HIR pretty printing.)
 - rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
 - rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19)
 - rust-lang#140465 (chore: edit and move tests)
 - rust-lang#140467 (Don't FCW assoc consts in patterns)
 - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
 - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
 - rust-lang#140476 (chore: delete unused ui/auxiliary crates)
 - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
 - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
 - rust-lang#140494 (Parser: Document restrictions)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge of rust-lang#140460 - heiher:issue-140455, r=Urgau
a7addb1 
Fix handling of LoongArch target features not supported by LLVM 19

Fixes rust-lang#140455
@Zalathar Zalathar mentioned this pull request Apr 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025
@bors
Auto merge of rust-lang#140510 - Zalathar:rollup-zcbws0g, r=Zalathar
902555b 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#140380 (transmutability: uninit transition matches unit byte only)
 - rust-lang#140385 (Subtree update of `rust-analyzer`)
 - rust-lang#140395 (organize and extend forbidden target feature tests)
 - rust-lang#140458 (Fix for async drop ice with partly dropped tuple)
 - rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19)
 - rust-lang#140465 (chore: edit and move tests)
 - rust-lang#140467 (Don't FCW assoc consts in patterns)
 - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing)
 - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4)
 - rust-lang#140476 (chore: delete unused ui/auxiliary crates)
 - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs)
 - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain)
 - rust-lang#140494 (Parser: Document restrictions)

r? `@ghost`
`@rustbot` modify labels: rollup
@RalfJung
Copy link
Member

RalfJung commented Apr 30, 2025 •
edited
Loading

Aren't there some tests for which min-llvm-version can be removed now? Namely all the ones where #138056 added that.

@RalfJung RalfJung mentioned this pull request Apr 30, 2025
Open
@RalfJung
Copy link
Member

RalfJung commented May 1, 2025

@bors r-

Please never push to approved PRs! If it got rolled up, it might get merged in its pre-push state, which leads to confusion.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 1, 2025
@heiher
Copy link
Contributor Author

heiher commented May 1, 2025

@bors r-

Please never push to approved PRs! If it got rolled up, it might get merged in its pre-push state, which leads to confusion.

Thank you for pointing that out! Would you recommend that I drop this commit and open a new PR instead?

@RalfJung
Copy link
Member

RalfJung commented May 1, 2025

Now that you made it we might as well land it with this PR. In future, if you want to change a PR after it got approved, just ask your reviewer to r- before pushing. :)

@RalfJung RalfJung added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoongArch target features not supported by LLVM 19 are not handled properly
6 participants
@heiher @rustbot @Urgau @bors @RalfJung @petrochenkov