Skip to content

Fix for async drop ice with partly dropped tuple #140458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for async drop ice with partly dropped tuple #140458

wants to merge 1 commit into from

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Apr 29, 2025

Fixes #140427.
Problem was with block data access with block id from new added blocks in patch.

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@azhogin
Copy link
Contributor Author

azhogin commented Apr 29, 2025

r? oli-obk

@rustbot rustbot assigned oli-obk and unassigned lcnr Apr 29, 2025
This was referenced Apr 29, 2025
Open
Open
@oli-obk
Copy link
Contributor

oli-obk commented Apr 29, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 29, 2025

📌 Commit f420ceb has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Apr 29, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Apr 29, 2025 •
edited
Loading

needs rustfmt

@azhogin azhogin force-pushed the azhogin/async-drop-fix-dropped-tuple-ice branch from f420ceb to cce706e Compare April 29, 2025 14:41
@oli-obk
Copy link
Contributor

oli-obk commented Apr 29, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 29, 2025

📌 Commit cce706e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025
@Zalathar
Rollup merge of rust-lang#140458 - azhogin:azhogin/async-drop-fix-dro…
4cb39af 
…pped-tuple-ice, r=oli-obk

Fix for async drop ice with partly dropped tuple

Fixes rust-lang#140427.
Problem was with block data access with block id from new added blocks in patch.
@Zalathar Zalathar mentioned this pull request Apr 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async drop ice with partly dropped tuple
6 participants
@azhogin @rustbot @oli-obk @bors @rust-log-analyzer @lcnr