Improve test coverage of HIR pretty printing. #140430

nnethercote · 2025-04-29T05:52:15Z

Details in individual commits.

r? @dtolnay

try-job: test-various

dtolnay

Thank you!

dtolnay · 2025-04-30T04:59:09Z

@bors r+

bors · 2025-04-30T04:59:11Z

📌 Commit 0004b51 has been approved by dtolnay

It is now in the queue for this repository.

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay`

Rollup of 14 pull requests Successful merges: - rust-lang#140380 (transmutability: uninit transition matches unit byte only) - rust-lang#140385 (Subtree update of `rust-analyzer`) - rust-lang#140395 (organize and extend forbidden target feature tests) - rust-lang#140430 (Improve test coverage of HIR pretty printing.) - rust-lang#140458 (Fix for async drop ice with partly dropped tuple) - rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19) - rust-lang#140465 (chore: edit and move tests) - rust-lang#140467 (Don't FCW assoc consts in patterns) - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing) - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4) - rust-lang#140476 (chore: delete unused ui/auxiliary crates) - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs) - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain) - rust-lang#140494 (Parser: Document restrictions) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-04-30T12:16:59Z

Failed in rollup: #140501 (comment)

Probably due to a soft conflict with the restrictions introduced by #139720.

@bors r-

bors · 2025-04-30T16:27:59Z

☔ The latest upstream changes (presumably #140503) made this pull request unmergeable. Please resolve the merge conflicts.

nnethercote · 2025-05-01T00:44:40Z

I rebased and added the missing ERROR markers.

@bors r=dtolnay

bors · 2025-05-01T00:44:43Z

📌 Commit 69e54ae has been approved by dtolnay

It is now in the queue for this repository.

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134034 (handle paren in macro expand for let-init-else expr) - rust-lang#139186 (Refactor `diy_float`) - rust-lang#140062 (std: mention `remove_dir_all` can emit `DirectoryNotEmpty` when concurrently written into) - rust-lang#140430 (Improve test coverage of HIR pretty printing.) - rust-lang#140485 (Optimize the codegen for `Span::from_expansion`) - rust-lang#140505 (linker: Quote symbol names in .def files) - rust-lang#140521 (interpret: better error message for out-of-bounds pointer arithmetic and accesses) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-05-01T08:38:34Z

Failed in rollup: #140537 (comment)

My condolences on having to think about the test-various job.

@bors r-

nnethercote · 2025-05-01T09:04:54Z

@bors try

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay`

bors · 2025-05-01T09:06:06Z

⌛ Trying commit 69e54ae with merge 127d9bc...

bors · 2025-05-01T11:15:02Z

☀️ Try build successful - checks-actions
Build commit: 127d9bc (127d9bc3430a4cfd918506a16692ef4fe6113f4e)

nnethercote · 2025-05-01T12:42:48Z

@bors try

bors · 2025-05-01T12:44:00Z

⌛ Trying commit a5dad1d with merge ec3351f4bc18eed148944fefcdf4486fcb79f769...

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay` try-job: test-various

bors · 2025-05-01T13:35:19Z

☀️ Try build successful - checks-actions
Build commit: ec3351f (ec3351f4bc18eed148944fefcdf4486fcb79f769)

nnethercote · 2025-05-01T20:54:39Z

The problem with the test-various job was caused by the use of asm! and global_asm! with x86-specific syntax. I have restricted the test to only run on x86-64/Linux.

@bors r=dtolnay

bors · 2025-05-01T20:54:41Z

📌 Commit a5dad1d has been approved by dtolnay

It is now in the queue for this repository.

nnethercote · 2025-05-02T00:12:16Z

@bors r-

By taking the existing `expanded-exhaustive.rs` test and running it with both `Zunpretty=expanded` *and* `Zunpretty=hir`. Also rename some files, and split the asm parts out so they only run on x86-64.

nnethercote · 2025-05-02T02:48:18Z

I have now split out the asm parts into a separate test that only runs on x86-64. The main test runs on all platforms. I also accidentally squashed the commits, oh well.

nnethercote · 2025-05-02T04:15:48Z

@bors try

bors · 2025-05-02T04:16:59Z

⌛ Trying commit 3f842e5 with merge 0acf01e326ee07ed2d542f32e0cce7bb3f4c357c...

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay` try-job: test-various

bors · 2025-05-02T05:08:07Z

☀️ Try build successful - checks-actions
Build commit: 0acf01e (0acf01e326ee07ed2d542f32e0cce7bb3f4c357c)

nnethercote · 2025-05-02T05:50:50Z

@bors r=dtolnay

bors · 2025-05-02T05:50:52Z

📌 Commit 3f842e5 has been approved by dtolnay

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - rust-lang#134034 (handle paren in macro expand for let-init-else expr) - rust-lang#137474 (pretty-print: Print shebang at the top of the output) - rust-lang#138872 (rustc_target: RISC-V `Zfinx` is incompatible with `{ILP32,LP64}[FD]` ABIs) - rust-lang#139046 (Improve `Lifetime::suggestion`) - rust-lang#139206 (std: use the address of `errno` to identify threads in `unique_thread_exit`) - rust-lang#139608 (Clarify `async` block behaviour) - rust-lang#139847 (Delegate to inner `vec::IntoIter` from `env::ArgsOs`) - rust-lang#140159 (Avoid redundant WTF-8 checks in `PathBuf`) - rust-lang#140197 (Document breaking out of a named code block) - rust-lang#140389 (Remove `avx512dq` and `avx512vl` implication for `avx512fp16`) - rust-lang#140430 (Improve test coverage of HIR pretty printing.) - rust-lang#140507 (rustc_target: RISC-V: feature addition batch 3) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#140430 - nnethercote:hir-exhaustive, r=dtolnay Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay` try-job: test-various

rustbot assigned dtolnay Apr 29, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025

dtolnay approved these changes Apr 30, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025

Rollup merge of rust-lang#140430 - nnethercote:hir-exhaustive, r=dtolnay

5527d94

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay`

Zalathar mentioned this pull request Apr 30, 2025

Rollup of 14 pull requests #140501

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2025

nnethercote force-pushed the hir-exhaustive branch from 0004b51 to 69e54ae Compare May 1, 2025 00:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 1, 2025

Rollup merge of rust-lang#140430 - nnethercote:hir-exhaustive, r=dtolnay

ebd9291

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay`

matthiaskrgr mentioned this pull request May 1, 2025

Rollup of 7 pull requests #140537

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 1, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2025

Auto merge of rust-lang#140430 - nnethercote:hir-exhaustive, r=<try>

127d9bc

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay`

This comment has been minimized.

Sign in to view

nnethercote force-pushed the hir-exhaustive branch from 2ca273d to a5dad1d Compare May 1, 2025 12:38

bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2025

Auto merge of rust-lang#140430 - nnethercote:hir-exhaustive, r=<try>

ec3351f

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay` try-job: test-various

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 2, 2025

Improve coverage of HIR pretty printing.

3f842e5

By taking the existing `expanded-exhaustive.rs` test and running it with both `Zunpretty=expanded` *and* `Zunpretty=hir`. Also rename some files, and split the asm parts out so they only run on x86-64.

nnethercote force-pushed the hir-exhaustive branch from a5dad1d to 3f842e5 Compare May 2, 2025 02:47

bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2025

Auto merge of rust-lang#140430 - nnethercote:hir-exhaustive, r=<try>

0acf01e

Improve test coverage of HIR pretty printing. Details in individual commits. r? `@dtolnay` try-job: test-various

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2025

Zalathar mentioned this pull request May 2, 2025

Rollup of 12 pull requests #140581

Merged

bors merged commit 01adc82 into rust-lang:master May 2, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone May 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve test coverage of HIR pretty printing. #140430

Improve test coverage of HIR pretty printing. #140430

nnethercote commented Apr 29, 2025 •

edited by Kobzol

Loading

dtolnay left a comment

dtolnay commented Apr 30, 2025

bors commented Apr 30, 2025

Zalathar commented Apr 30, 2025

bors commented Apr 30, 2025

nnethercote commented May 1, 2025

bors commented May 1, 2025

Zalathar commented May 1, 2025

nnethercote commented May 1, 2025

bors commented May 1, 2025

bors commented May 1, 2025

This comment has been minimized.

This comment has been minimized.

nnethercote commented May 1, 2025

bors commented May 1, 2025

bors commented May 1, 2025

nnethercote commented May 1, 2025

bors commented May 1, 2025

nnethercote commented May 2, 2025

nnethercote commented May 2, 2025 •

edited

Loading

nnethercote commented May 2, 2025

bors commented May 2, 2025

bors commented May 2, 2025

nnethercote commented May 2, 2025

bors commented May 2, 2025

Improve test coverage of HIR pretty printing. #140430

Improve test coverage of HIR pretty printing. #140430

Conversation

nnethercote commented Apr 29, 2025 • edited by Kobzol Loading

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented Apr 30, 2025

bors commented Apr 30, 2025

Zalathar commented Apr 30, 2025

bors commented Apr 30, 2025

nnethercote commented May 1, 2025

bors commented May 1, 2025

Zalathar commented May 1, 2025

nnethercote commented May 1, 2025

bors commented May 1, 2025

bors commented May 1, 2025

This comment has been minimized.

This comment has been minimized.

nnethercote commented May 1, 2025

bors commented May 1, 2025

bors commented May 1, 2025

nnethercote commented May 1, 2025

bors commented May 1, 2025

nnethercote commented May 2, 2025

nnethercote commented May 2, 2025 • edited Loading

nnethercote commented May 2, 2025

bors commented May 2, 2025

bors commented May 2, 2025

nnethercote commented May 2, 2025

bors commented May 2, 2025

nnethercote commented Apr 29, 2025 •

edited by Kobzol

Loading

nnethercote commented May 2, 2025 •

edited

Loading