Skip to content

Use search_for_cycle_permutation to look for variances_of #140358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 27, 2025

This uses search_for_cycle_permutation to look for variances_of in case variances_of is not the first query in the cycle.

This may fix #124423 and #127971.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Apr 27, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

📌 Commit c33b4f8 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#140246 (Fix never pattern printing)
 - rust-lang#140280 (Improve if/else pretty printing)
 - rust-lang#140348 (Update lint-docs to default to Rust 2024)
 - rust-lang#140358 (Use `search_for_cycle_permutation` to look for `variances_of`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fdfc7c0 into rust-lang:master Apr 27, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
Rollup merge of rust-lang#140358 - Zoxc:variance-cycle, r=oli-obk

Use `search_for_cycle_permutation` to look for `variances_of`

This uses `search_for_cycle_permutation` to look for `variances_of` in case `variances_of` is not the first query in the cycle.

This may fix rust-lang#124423 and rust-lang#127971.

r? `@oli-obk`
@rustbot rustbot added this to the 1.88.0 milestone Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: 'only variances_of returns &[ty::Variance]'
4 participants