Skip to content

uefi: Update r-efi #138737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

uefi: Update r-efi #138737

wants to merge 2 commits into from
+10 −10

Conversation

Ayush1325
Copy link
Contributor

@Ayush1325 Ayush1325 commented Mar 20, 2025 •
edited by tgross35
Loading

  • Bump up the version to 5.2.0

try-job: x86_64-gnu-distcheck
try-job: x86_64-gnu
try-job: test-various

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Ayush1325
Copy link
Contributor Author

@rustbot label +O-UEFI

@rustbot rustbot added the O-UEFI UEFI label Apr 11, 2025
@Ayush1325 Ayush1325 marked this pull request as ready for review April 25, 2025 15:57
@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2025

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@Ayush1325
uefi: Update r-efi
59b6cf5 
- Bump up the version to 5.2.0

Signed-off-by: Ayush Singh <[email protected]>
@tgross35
Copy link
Contributor

The breaking change at 5.0 seems to be about Unload, which I don't see us using anywhere https://github.com/r-efi/r-efi/releases/tag/v5.0.0.

r? tgross35
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

📌 Commit 59b6cf5 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Apr 27, 2025
@tgross35
Rollup merge of rust-lang#138737 - Ayush1325:r-efi-update, r=tgross35
4cf8048 
uefi: Update r-efi

- Bump up the version to 5.2.0
@tgross35 tgross35 mentioned this pull request Apr 27, 2025
Closed
tgross35 added a commit to tgross35/rust that referenced this pull request Apr 27, 2025
@tgross35
Rollup merge of rust-lang#138737 - Ayush1325:r-efi-update, r=tgross35
2e6c07b 
uefi: Update r-efi

- Bump up the version to 5.2.0
@tgross35 tgross35 mentioned this pull request Apr 27, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
@bors
Auto merge of rust-lang#140355 - tgross35:rollup-sean6my, r=tgross35
39658ed 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#137439 (Stabilise `std::ffi::c_str`)
 - rust-lang#138737 (uefi: Update r-efi)
 - rust-lang#139646 (check types of const param defaults)
 - rust-lang#140220 (Fix detection of main function if there are expressions around it)
 - rust-lang#140291 (Correctly display stdout and stderr in case a doctest is failing)
 - rust-lang#140297 (Update example to use CStr::to_string_lossy)
 - rust-lang#140330 (Clarified bootstrap optimization "true" argument)

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35
Copy link
Contributor

@bors r-

Failed in #140355 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 27, 2025
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 27, 2025
@tgross35
Copy link
Contributor

@bors try

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

⌛ Trying commit d40d424 with merge e423732...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2025
@bors
Auto merge of rust-lang#138737 - Ayush1325:r-efi-update, r=<try>
e423732 
uefi: Update r-efi

- Bump up the version to 5.2.0

try-job: x86_64-gnu-distcheck
try-job: x86_64-gnu
try-job: test-various
@bors
Copy link
Collaborator

bors commented Apr 27, 2025

☀️ Try build successful - checks-actions
Build commit: e423732 (e4237322ddb81b5259cb849b1143093bc60c012e)

@Ayush1325
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2025
@tgross35
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

📌 Commit d40d424 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ayush1325 @rustbot @rust-log-analyzer @tgross35 @bors @workingjubilee