-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncFn*
to core
prelude
#135852
Open
lukas-code
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
lukas-code:asyncfn-prelude-core
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add AsyncFn*
to core
prelude
#135852
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jan 22, 2025
whoops :) i think it's obvious enough that this was an oversight that i'll just r+ this now @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 22, 2025
Nominating for beta, so this can land together with async closures and the traits in the @rustbot label beta-nominated T-libs-api -T-libs |
rustbot
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
and removed
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jan 22, 2025
@bors rollup |
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jan 22, 2025
…=compiler-errors Add `AsyncFn*` to `core` prelude In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight. r? libs-api cc `@compiler-errors`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#135779 (CI: free disk on linux arm runner) - rust-lang#135794 (Detect missing fields with default values and suggest `..`) - rust-lang#135814 (ci: use ghcr buildkit image) - rust-lang#135818 (tests: Port `translation` to rmake.rs) - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets) - rust-lang#135837 (Remove test panic from File::open) - rust-lang#135852 (Add `AsyncFn*` to `core` prelude) - rust-lang#135856 (Library: Finalize dyn compatibility renaming) r? `@ghost` `@rustbot` modify labels: rollup
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jan 22, 2025
…=compiler-errors Add `AsyncFn*` to `core` prelude In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight. r? libs-api cc ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-nominated
Nominated for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #132611 these got added to the
std
prelude only, which looks like an oversight.r? libs-api
cc @compiler-errors