Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncFn* to core prelude #135852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukas-code
Copy link
Member

In #132611 these got added to the std prelude only, which looks like an oversight.

r? libs-api
cc @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@compiler-errors
Copy link
Member

whoops :)

i think it's obvious enough that this was an oversight that i'll just r+ this now

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2025

📌 Commit cc19dfa has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2025
@lukas-code
Copy link
Member Author

Nominating for beta, so this can land together with async closures and the traits in the std prelude.

@rustbot label beta-nominated T-libs-api -T-libs

@rustbot rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
@lukas-code
Copy link
Member Author

@bors rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 22, 2025
…=compiler-errors

Add `AsyncFn*` to `core` prelude

In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight.

r? libs-api
cc `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#135779 (CI: free disk on linux arm runner)
 - rust-lang#135794 (Detect missing fields with default values and suggest `..`)
 - rust-lang#135814 (ci: use ghcr buildkit image)
 - rust-lang#135818 (tests: Port `translation` to rmake.rs)
 - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets)
 - rust-lang#135837 (Remove test panic from File::open)
 - rust-lang#135852 (Add `AsyncFn*` to `core` prelude)
 - rust-lang#135856 (Library: Finalize dyn compatibility renaming)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 22, 2025
…=compiler-errors

Add `AsyncFn*` to `core` prelude

In rust-lang#132611 these got added to the `std` prelude only, which looks like an oversight.

r? libs-api
cc ``@compiler-errors``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants