-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply LTO config to rustdoc #135832
base: master
Are you sure you want to change the base?
Apply LTO config to rustdoc #135832
Conversation
That's a good imrovement. You may want to add a change entry for this :) |
Ok, I'll do that. Let's also double check that the perf. win applies on this PR. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Apply LTO config to rustdoc Before, the LTO configuration from `config.toml` was not applied to `rustdoc`. This provides a small perf. and binary size [win](rust-lang#112049 (comment)) for doc builds. Since this is configured with Cargo profiles and not rustflags, it should not break tool build cache (rust-lang#131155). I tried to run `x test miri`, `x test rustdoc` and `x test miri` and nothing was rebuilt. r? `@onur-ozkan`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (5f13723): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.328s -> 765.487s (0.15%) |
Before, the LTO configuration from `config.toml` was not applied to `rustdoc`.
Updated the change tracker. @rustbot ready |
Before, the LTO configuration from
config.toml
was not applied torustdoc
. This provides a small perf. and binary size win for doc builds.Since this is configured with Cargo profiles and not rustflags, it should not break tool build cache (#131155). I tried to run
x test miri
,x test rustdoc
andx test miri
and nothing was rebuilt.r? @onur-ozkan