Improve display of const unstable display feature info #135830
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
GuillaumeGomez
changed the title
|
If this works with methods, can you add an example and test case for that? Or, if not, mention that it doesn't work in the PR? |
|
Same code for both but you're right, better ensure it. |
GuillaumeGomez
force-pushed
the
const-unstable-item-info
branch
from
b77b18a to
a6bbf15
Compare
|
Extended test to check on methods as well and added screenshot. |
notriddle
added
T-rustdoc-frontend
|
@rfcbot poll |
|
Team member @notriddle has asked teams: T-rustdoc-frontend, for consensus on: |
|
This seems a little too similar to normal unstable API annotations to me. Skimming the docs I think I would miss the const word and just overlook the method as unstable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131618.
It looks like this:
And like this for methods:
You can check it online here.
r? @notriddle