Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support each_ref and each_mut in [T; N] in constant expressions. #133288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjoernager
Copy link
Contributor

@bjoernager bjoernager commented Nov 21, 2024

Tracking issue: #133289

The methods <[T; N]>::each_ref and <[T; N]>::each_mut can easily be reimplemented to allow marking them with the const specifier.

This specific implementation takes a different approach than the original as to avoid using iterators (which are illegal in constant expressions).

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 21, 2024
@bjoernager
Copy link
Contributor Author

r? libs-api

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 21, 2024
@rustbot rustbot assigned BurntSushi and unassigned jhpratt Nov 21, 2024
@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 21, 2024
@bjoernager
Copy link
Contributor Author

Should lifetimes be explicit here or can the compiler still deduce that they derive from that of self?

@bjoernager
Copy link
Contributor Author

E.g.:

pub const fn each_ref<'a>(&'a self) -> [&'a T; N];

Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should lifetimes be explicit here or can the compiler still deduce that they derive from that of self?

Not an issue; the compiler is able to infer them as intended.

library/core/src/array/mod.rs Show resolved Hide resolved
@jhpratt jhpratt assigned jhpratt and unassigned BurntSushi Nov 22, 2024
@jhpratt jhpratt added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2024
@jhpratt
Copy link
Member

jhpratt commented Nov 22, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Nov 22, 2024

📌 Commit 7c799c3 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants