Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triagebot: Consolidate the T-compiler ad hoc assignment groups #132923

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Nov 11, 2024

rust-lang/compiler-team#757

  1. Inline compiler-team and compiler-team-contributors into compiler
  2. Sort members alphabetically

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@fmease fmease changed the title Triagebot: Consolidate the T-compiler ad hoc groups Triagebot: Consolidate the T-compiler ad hoc assignment groups Nov 11, 2024
@fmease
Copy link
Member Author

fmease commented Nov 11, 2024

Alternatively, we could apply the following change or similar:

- compiler-team = [...]
- compiler-team-contributors = [...]
- compiler = ["compiler-team", "compiler-team-contributors"]
+ compiler-team-members = [...]
+ compiler-maintainers = [...]
+ compiler = ["compiler-team-members", "compiler-maintainers"]

@wesleywiser
Copy link
Member

Thanks @fmease!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 12, 2024

📌 Commit 5b7423c has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#131831 (extend the "if-unchanged" logic for compiler builds)
 - rust-lang#132541 (Proper support for cross-crate recursive const stability checks)
 - rust-lang#132657 (AIX: add run-make support)
 - rust-lang#132901 (Warn about invalid `mir-enable-passes` pass names)
 - rust-lang#132923 (Triagebot: Consolidate the T-compiler ad hoc assignment groups)
 - rust-lang#132938 (Make precise capturing suggestion machine-applicable only if it has no APITs)
 - rust-lang#132947 (clarify `must_produce_diag` ICE for debugging)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15fbae8 into rust-lang:master Nov 12, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
Rollup merge of rust-lang#132923 - fmease:triagebot-update-t-compiler, r=wesleywiser

Triagebot: Consolidate the T-compiler ad hoc assignment groups

rust-lang/compiler-team#757

1. Inline compiler-team and compiler-team-contributors into compiler
2. Sort members alphabetically
@fmease fmease deleted the triagebot-update-t-compiler branch November 12, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants