Add more mailmap entries #132474
Merged
Add more mailmap entries #132474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-meta
workingjubilee
approved these changes
Nov 1, 2024
Noratrieb
force-pushed
the
lots-of-mailmapping-round-2
branch
from
84bc564 to
a04081b
Compare
|
Added a few additional ones: @b-naber @Centri3 @nikomatsakis @nikic |
TimNN
suggested changes
Nov 1, 2024
Noratrieb
force-pushed
the
lots-of-mailmapping-round-2
branch
from
5a65d9d to
18b47b8
Compare
WaffleLapkin
approved these changes
Nov 1, 2024
apiraino
reviewed
Nov 2, 2024
fmease
reviewed
Nov 2, 2024
There was a problem hiding this comment.
I've noticed Jieyou Xu also shows up at least twice on thanks/all. Once as Jieyou Xu <********@**********> and once as 许杰友 Jieyou Xu (Joe) <********@**********> (I've redacted the email addresses but they are the same). There's already a mailmap entry for them but it should be extended.
|
my additional entry fixes this |
apiraino
approved these changes
Nov 2, 2024
shepmaster
reviewed
Nov 4, 2024
|
r=me whenever |
Mark-Simulacrum
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #133728) made this pull request unmergeable. Please resolve the merge conflicts. |
Noratrieb
force-pushed
the
lots-of-mailmapping-round-2
branch
from
dc5f2ac to
8c0c5e2
Compare
The people updated in this commit have contributed under different email addresses than the ones they have used in rust-lang/team. A new change will use team data for thanks reviewers, which requires this to be in sync. Therefore, I have updated many of the people that I've noticed being duplicated after the change.
Noratrieb
force-pushed
the
lots-of-mailmapping-round-2
branch
from
8c0c5e2 to
a985205
Compare
|
It's been a while, everyone had time to correct their entries. If something turns out to be wrong anyways, you can of course always submit a new PR fixing your entries. |
bors
added
S-waiting-on-bors
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Dec 31, 2024
…d-2, r=Mark-Simulacrum Add more mailmap entries If you have been pinged: I'm adding a mailmap entry for you to keep thanks.rust-lang.org working properly. **I have picked the canonical address mostly arbitrarily. If you want a different one as the canonical address, please tell me here**. <details> <summary>more details on the change</summary> builds on top of rust-lang#132471, this containing the less obvious changes that add new canonical email addresses instead of just adding new current ones. The people updated in this commit have contributed under different email addresses than the ones they have used in rust-lang/team. rust-lang/thanks#53 will use team data for thanks reviewers, which requires this to be in sync. Therefore, I have updated many of the people that I've noticed being duplicated after the change. </details> I'm adding a novel entry for you: `@apiraino` `@KodrAus` `@cramertj` `@sunfishcode` `@Eh2406` `@skade` `@huonw` `@jsha` `@shepmaster` `@workingjubilee` `@rbtcollins` `@nrc` `@fitzgen` `@sophiajt` `@tmiasko` `@notriddle` `@TimNN` `@WaffleLapkin`
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Dec 31, 2024
add .mailmap entry for myself Seeing rust-lang#132474 in the bors queue I decided to check myself and noticed I was listed four times. This fixed that by cannonicalizing all entries to use my username and the github no-reply email address, rather than some combination of name or username and different email addresses.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#132474 (Add more mailmap entries) - rust-lang#133486 (borrowck diagnostics: make `add_move_error_suggestions` use the HIR rather than `SourceMap`) - rust-lang#134063 (dec2flt: Clean up float parsing modules) - rust-lang#134861 (Add GUI test for item info elements color) - rust-lang#134968 (Print how to rebless Python formatting in tidy) - rust-lang#134971 (chore: fix typos) - rust-lang#134972 (add .mailmap entry for myself) - rust-lang#134974 (Revert rust-lang#119515 single line where clause style guide) - rust-lang#134975 (Revert style guide rhs break) r? `@ghost` `@rustbot` modify labels: rollup
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Dec 31, 2024
add .mailmap entry for myself Seeing rust-lang#132474 in the bors queue I decided to check myself and noticed I was listed four times. This fixed that by cannonicalizing all entries to use my username and the github no-reply email address, rather than some combination of name or username and different email addresses.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#132474 (Add more mailmap entries) - rust-lang#133486 (borrowck diagnostics: make `add_move_error_suggestions` use the HIR rather than `SourceMap`) - rust-lang#134861 (Add GUI test for item info elements color) - rust-lang#134968 (Print how to rebless Python formatting in tidy) - rust-lang#134971 (chore: fix typos) - rust-lang#134972 (add .mailmap entry for myself) - rust-lang#134974 (Revert rust-lang#119515 single line where clause style guide) - rust-lang#134975 (Revert style guide rhs break) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
Rollup merge of rust-lang#134972 - Skgland:master, r=Noratrieb add .mailmap entry for myself Seeing rust-lang#132474 in the bors queue I decided to check myself and noticed I was listed four times. This fixed that by cannonicalizing all entries to use my username and the github no-reply email address, rather than some combination of name or username and different email addresses.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2025
Rollup merge of rust-lang#132474 - Noratrieb:lots-of-mailmapping-round-2, r=Mark-Simulacrum Add more mailmap entries If you have been pinged: I'm adding a mailmap entry for you to keep thanks.rust-lang.org working properly. **I have picked the canonical address mostly arbitrarily. If you want a different one as the canonical address, please tell me here**. <details> <summary>more details on the change</summary> builds on top of rust-lang#132471, this containing the less obvious changes that add new canonical email addresses instead of just adding new current ones. The people updated in this commit have contributed under different email addresses than the ones they have used in rust-lang/team. rust-lang/thanks#53 will use team data for thanks reviewers, which requires this to be in sync. Therefore, I have updated many of the people that I've noticed being duplicated after the change. </details> I'm adding a novel entry for you: ``@apiraino`` ``@KodrAus`` ``@cramertj`` ``@sunfishcode`` ``@Eh2406`` ``@skade`` ``@huonw`` ``@jsha`` ``@shepmaster`` ``@workingjubilee`` ``@rbtcollins`` ``@nrc`` ``@fitzgen`` ``@sophiajt`` ``@tmiasko`` ``@notriddle`` ``@TimNN`` ``@WaffleLapkin``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have been pinged: I'm adding a mailmap entry for you to keep thanks.rust-lang.org working properly.
I have picked the canonical address mostly arbitrarily. If you want a different one as the canonical address, please tell me here.
more details on the change
builds on top of #132471, this containing the less obvious changes that add new canonical email addresses instead of just adding new current ones.
The people updated in this commit have contributed under different email
addresses than the ones they have used in rust-lang/team.
rust-lang/thanks#53 will use team data for thanks reviewers, which requires this to be in
sync.
Therefore, I have updated many of the people that I've noticed being
duplicated after the change.
I'm adding a novel entry for you: @apiraino @KodrAus @cramertj @sunfishcode @Eh2406 @skade @huonw @jsha @shepmaster @workingjubilee @rbtcollins @nrc @fitzgen @sophiajt @tmiasko @notriddle @TimNN @WaffleLapkin