Support input/output in vector registers of s390x inline assembly #131664
+677
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
10 tasks
rustbot
removed
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #131672) made this pull request unmergeable. Please resolve the merge conflicts. |
taiki-e
force-pushed
the
s390x-asm-vreg-inout
branch
from
107fef5
to
57419c1
Compare
|
☔ The latest upstream changes (presumably #132152) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #133006) made this pull request unmergeable. Please resolve the merge conflicts. |
taiki-e
force-pushed
the
s390x-asm-vreg-inout
branch
from
57419c1
to
a9476db
Compare
taiki-e
changed the title
|
Some changes occurred in compiler/rustc_codegen_gcc |
taiki-e
force-pushed
the
s390x-asm-vreg-inout
branch
from
a9476db
to
d0a124a
Compare
taiki-e
changed the title
taiki-e
force-pushed
the
s390x-asm-vreg-inout
branch
2 times, most recently
from
d0a124a
to
51506f9
Compare
taiki-e
changed the title
taiki-e
force-pushed
the
s390x-asm-vreg-inout
branch
from
51506f9
to
b6b9f79
Compare
taiki-e
force-pushed
the
s390x-asm-vreg-inout
branch
from
b6b9f79
to
2c8f6de
Compare
taiki-e
changed the title
rustbot
added
S-waiting-on-review
|
Is there a way to feature-gate this functionality? Since s390x asm support is stable, every change here needs to go through an FCP since it will instantly be stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends currently clobber-only vector registers (
vreg) support to allow passing#[repr(simd)]types, floats (f32/f64/f128), and integers (i32/i64/i128) as input/output.vregvectori32,f32,i64,f64,i128,f128,i8x16,i16x8,i32x4,i64x2,f32x4,f64x2This matches the list of types that are supported by the vector registers in LLVM:
https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.td#L301-L313
In addition to
core::simdtypes and floats listed above, custom#[repr(simd)]types of the same size and type are also allowed. All allowed types other than i32/f32/i64/f64/i128, and relevant target features are currently unstable.Currently there is no SIMD type for s390x in
core::arch, but this is tracked in #130869.cc #130869 about vector facility support in s390x
cc #125398 & #116909 about f128 support in asm
@rustbot label +O-SystemZ +A-inline-assembly