-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Handle rustc_resolve
cases of rustc::potential_query_instability
lint
#131213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ismailarilik
wants to merge
15
commits into
rust-lang:master
from
ismailarilik:handle-potential-query-instability-lint-for-rustc-resolve
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fb9cc98
Handle `rustc_resolve` cases of `rustc::potential_query_instability` …
ismailarilik da17709
Add requested changes by reviewer
ismailarilik 34c78ce
Specify sort location in a comment
ismailarilik aeac8a8
Specify sort location in a comment
ismailarilik 64d3961
Specify sort location in a comment
ismailarilik 1121d65
Clarify reasoning behind allowing this lint in a comment
ismailarilik 9652373
Clarify reasoning behind allowing this lint in a comment
ismailarilik e592d73
Clarify reasoning behind allowing this lint in a comment
ismailarilik 477de93
Specify sort location in a comment
ismailarilik 93ab85f
Sort suggestions in diagnostics to make error reporting deterministic
ismailarilik 5d14c34
Revert unused_arms to HashMap; they are already sorted so no need to …
ismailarilik f09b6a8
Try to sort `single_imports` before usage to have a stable result
ismailarilik 0ecb033
Try to sort bindings before usage to have a stable result
ismailarilik 2ff01e8
Use `swap_remove` instead of `shift_remove`
ismailarilik 0944d8c
Sort `idents` before usage instead of `suggestions` to have a stable …
ismailarilik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.