Use DefId
instead of Span
in BrAnon
to avoid stable hashing collisions
#104274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent reports of ICEs due to the fact that
BrAnon
regions now capture spans, which apparently sometimes canStableHash
into identical values butHash
into different values, causing collisions in dep nodes that are not covered by identical cache entries.We can avoid this by just using a
DefId
insteadwhich doesn't affect diagnosticsedit: this is not true.I have no idea how to turn #104271, #104255, or #104238 into a MCVE, though, but local testing shows that the projects build without ICE after this change.
This brings up a bigger question about whether we should be rejecting
Span
s from query keys (or at least being much more careful about them)...Fixes #104271
Fixes #104255
Fixes #104238
cc #103171 @cjgillot @jackh726